Skip to contentSkip to conversation

crypto: s390/sha256 - rename module to sha256-s390

PATCH In review Eric Biggers 2 participants 2 messages May 29, 2025 – May 30, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: s390/sha256 - rename module to sha256-s390

From: Eric Biggers <[email protected]>

When the s390 SHA-256 code is built as a loadable module, name it sha256-s390.ko instead of sha256.ko. This avoids a module name collision with crypto/sha256.ko and makes it consistent with the other architectures.

We should consider making a single module provide all the SHA-256 library code, which would prevent issues like this. But for now this is the fix that's needed.

Fixes b9eac03edcf8 ("crypto: s390/sha256 - implement library instead of shash")
---
 arch/s390/lib/crypto/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/s390/lib/crypto/Makefile +2 -1
index 920197967f463..5df30f1e79307 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
 obj-$(CONFIG_CRYPTO_CHACHA_S390) += chacha_s390.o
 chacha_s390-y := chacha-glue.o chacha-s390.o
 
-obj-$(CONFIG_CRYPTO_SHA256_S390) += sha256.o
+obj-$(CONFIG_CRYPTO_SHA256_S390) += sha256-s390.o
+sha256-s390-y := sha256.o

base-commit: e0797d3b91de75b6c95b4a0e0649ebd4aac1d9d1

Signature · 1 line
2.49.0
maintainer
#1 lore raw
Quoted 11 lines · Eric Biggers

From: Eric Biggers <[email protected]>

When the s390 SHA-256 code is built as a loadable module, name it sha256-s390.ko instead of sha256.ko. This avoids a module name collision with crypto/sha256.ko and makes it consistent with the other architectures.

We should consider making a single module provide all the SHA-256 library code, which would prevent issues like this. But for now this is the fix that's needed.

Quoted 7 lines
Fixes b9eac03edcf8 ("crypto: s390/sha256 - implement library instead of shash")

---
arch/s390/lib/crypto/Makefile | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt