Skip to contentSkip to conversation

md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue

PATCH Applied Ryo Takakura 3 participants 3 messages Jun 1, 2025 – Jun 14, 2025 MD RAID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue

When specified with WQ_CPU_INTENSIVE, the workqueue doesn't participate in concurrency management. This behaviour is already accounted for WQ_UNBOUND workqueues given that they are assigned to their own worker threads.

Unset WQ_CPU_INTENSIVE as the use of flag has no effect when used with WQ_UNBOUND.

---

Hi!

My understanding is that unbound wqs are served by non concurrency managed worker threads and is not tracked by wq_cpu_intensive_report(), so this should have no change in behaviour.

Sincerely,
Ryo Takakura

---
 drivers/md/raid5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/raid5.c +1 -1
index 638938316..8f3b45161 100644
@@ -9048,7 +9048,7 @@ static int __init raid5_init(void)
 	int ret;
 
 	raid5_wq = alloc_workqueue("raid5wq",
-		WQ_UNBOUND|WQ_MEM_RECLAIM|WQ_CPU_INTENSIVE|WQ_SYSFS, 0);
+		WQ_UNBOUND|WQ_MEM_RECLAIM|WQ_SYSFS, 0);
 	if (!raid5_wq)
 		return -ENOMEM;
 
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Ryo Takakura

When specified with WQ_CPU_INTENSIVE, the workqueue doesn't participate in concurrency management. This behaviour is already accounted for WQ_UNBOUND workqueues given that they are assigned to their own worker threads.

Unset WQ_CPU_INTENSIVE as the use of flag has no effect when used with WQ_UNBOUND.

Thanks.

Signature · 1 line
tejun
Applied
#2 lore raw
In reply to Ryo Takakura
Quoted 10 lines · Ryo Takakura

When specified with WQ_CPU_INTENSIVE, the workqueue doesn't participate in concurrency management. This behaviour is already accounted for WQ_UNBOUND workqueues given that they are assigned to their own worker threads.

Unset WQ_CPU_INTENSIVE as the use of flag has no effect when used with WQ_UNBOUND.

---

Applied to md-6.16

Thanks
Kuai