smb: client: add NULL check in automount_fullpath
Subsystems (2)
PATCH 1/1 smb: client: add NULL check in automount_fullpath
page is checked for null in __build_path_from_dentry_optional_prefix when tcon->origin_fullpath is not set. However, the check is missing when it is set.
Add a check to prevent a potential NULL pointer dereference.
Signed-off-by Ruben Devos <[email protected]>
--- fs/smb/client/namespace.c | 3 +++ 1 file changed, 3 insertions(+)
fs/smb/client/namespace.c +3 -0
@@ -146,6 +146,9 @@ static char *automount_fullpath(struct dentry *dentry, void *page) }spin_unlock (&tcon->tc_lock); +if (unlikely (!page)) +return ERR_PTR (-ENOMEM ); + s =dentry_path_raw (dentry, page,PATH_MAX );if (IS_ERR (s))return s;
Signature · 1 line
2.49.0
good catch. Added to cifs-2.6.git for-next, and added Cc: stable
Quoted 29 lines · Ruben Devos
page is checked for null in
__build_path_from_dentry_optional_prefixwhentcon->origin_fullpathis not set. However, the check is missing when it is set.
Add a check to prevent a potential NULL pointer dereference.Signed-off-by Ruben Devos <[email protected]>--- fs/smb/client/namespace.c | 3 +++ 1 file changed, 3 insertions(+)fs/smb/client/namespace.c +3
-1@@ -146,6 +146,9 @@ static char *automount_fullpath(struct dentry *dentry, void *page) }spin_unlock (&tcon->tc_lock); +if (unlikely (!page)) +return ERR_PTR (-ENOMEM ); + s =dentry_path_raw (dentry, page,PATH_MAX );if (IS_ERR (s))return s; --2.49.0
Signature · 3 lines
Thanks, Steve