module: make __mod_device_table__* symbols static
Subsystems (2)
PATCH 1/1 module: make __mod_device_table__* symbols static
The __mod_device_table__* symbols are only parsed by modpost to generate MODULE_ALIAS() entries from MODULE_DEVICE_TABLE().
Therefore, these symbols do not need to be globally visible, or globally unique.
If they are in the global scope, we would worry about the symbol uniqueness, but modpost is fine with parsing multiple symbols with the same name.
---
include/linux/module.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/module.h +2 -2
@@ -249,8 +249,8 @@ struct module_kobject *lookup_or_create_module_kobject(const char *name);#ifdef MODULE /* Creates an alias so file2alias.c can find device table. */ #define MODULE_DEVICE_TABLE (type, name) \ -extern typeof(name) __mod_device_table__##type##__##name \ - __attribute__ ((unused, alias(__stringify(name)))) +static typeof(name) __mod_device_table__##type##__##name \ + __attribute__ ((used, alias(__stringify(name))))#else /* !MODULE */ #define MODULE_DEVICE_TABLE (type, name)#endif
Signature · 1 line
2.43.0
Quoted 11 lines · Masahiro Yamada
The __mod_device_table__* symbols are only parsed by modpost to generate
MODULE_ALIAS()entries fromMODULE_DEVICE_TABLE().Therefore, these symbols do not need to be globally visible, or globally unique.
If they are in the global scope, we would worry about the symbol uniqueness, but modpost is fine with parsing multiple symbols with the same name.
Signed-off-by Masahiro Yamada <[email protected]>
Signature · 2 lines
Thanks, Petr
Quoted 12 lines · Petr Pavlu
Quoted 10 lines · Masahiro Yamada
The __mod_device_table__* symbols are only parsed by modpost to generate
MODULE_ALIAS()entries fromMODULE_DEVICE_TABLE().Therefore, these symbols do not need to be globally visible, or globally unique.
If they are in the global scope, we would worry about the symbol uniqueness, but modpost is fine with parsing multiple symbols with the same name.
Quoted 8 lines
Quoted 1 line
Signed-off-by Masahiro Yamada <[email protected]>Reviewed-by Petr Pavlu <[email protected]>--
Thanks,
Petr
Applied to linux-kbuild
Signature · 2 lines
Best Regards Masahiro Yamada