Skip to contentSkip to conversation

kernel/cpu/bugs: log ltf1 mitigation status

PATCH In review Khalid Ali 3 participants 4 messages Jun 2, 2025

Subsystems (2)
lore
Share & tools
lore

Khalid Ali

author
#0 lore raw

PATCH 1/1 kernel/cpu/bugs: log ltf1 mitigation status

Log the L1TF mitigation like other mitigatioons. This one is is the only one that doesn't get logged.

---
 arch/x86/kernel/cpu/bugs.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/bugs.c +1 -0
index 7f94e6a5497d..38cb2a1b2849 100644
@@ -2803,6 +2803,7 @@ static void __init l1tf_apply_mitigation(void)
 		return;
 	}
 
+	pr_info("Mitigation: PTE inversion\n");
 	setup_force_cpu_cap(X86_FEATURE_L1TF_PTEINV);
 }
 
Signature · 1 line
2.49.0
maintainer
#1 lore raw
Quoted 13 lines · Khalid Ali

Log the L1TF mitigation like other mitigatioons. This one is is the only one that doesn't get logged.

---
 arch/x86/kernel/cpu/bugs.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/bugs.c +0 -0
index 7f94e6a5497d..38cb2a1b2849 100644

arch/x86/kernel/cpu/bugs.c static void __init l1tf_apply_mitigation(void) · line 2808

Quoted 6 lines
arch/x86/kernel/cpu/bugs.c +1 -0
@@ -2803,6 +2803,7 @@ static void __init l1tf_apply_mitigation(void)
 		return;
 	}
 
+	pr_info("Mitigation: PTE inversion\n");
 	setup_force_cpu_cap(X86_FEATURE_L1TF_PTEINV);
 }

Pawan, what's the story here?

There's this stuff further down in that file:

| #define L1TF_DEFAULT_MSG "Mitigation: PTE Inversion"
|         
| #if IS_ENABLED(CONFIG_KVM_INTEL)
| static const char * const l1tf_vmx_states[] = {

which comes from 2018:

72c6d2db64fa ("x86/litf: Introduce vmx status variable")

I guess it is about time we made this mitigation also follow the common pattern with the mitigation strings and issuing them at the right time?

:-)

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
author
#2 lore raw
Quoted 31 lines
Quoted 13 lines

Log the L1TF mitigation like other mitigatioons. This one is is the only one that doesn't get logged.

---
arch/x86/kernel/cpu/bugs.c | 1 +

 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/bugs.c +0 -0
index 7f94e6a5497d..38cb2a1b2849 100644

arch/x86/kernel/cpu/bugs.c static void __init l1tf_apply_mitigation(void) · line 2808

Quoted 6 lines
arch/x86/kernel/cpu/bugs.c +1 -0
@@ -2803,6 +2803,7 @@ static void __init l1tf_apply_mitigation(void)
 		return;
 	}
 
+	pr_info("Mitigation: PTE inversion\n");
 	setup_force_cpu_cap(X86_FEATURE_L1TF_PTEINV);
 }

Pawan, what's the story here?

There's this stuff further down in that file:

| #define L1TF_DEFAULT_MSG "Mitigation: PTE Inversion"
|         
| #if IS_ENABLED(CONFIG_KVM_INTEL)
| static const char * const l1tf_vmx_states[] = {

which comes from 2018:

Quoted 8 lines

72c6d2db64fa ("x86/litf: Introduce vmx status variable")

I guess it is about time we made this mitigation also follow the common pattern with the mitigation strings and issuing them at the right time?

:-)

Thx.

Exactly, this mitigation is the only one doesn't have string, so i thought it is odd. Not only this but we need to make all mitigations consistent.

I think the commit you mentioned (72c6d2db64fa ("x86/litf: Introduce vmx status variable")) and mine have different context (one related to vmx and other common options), and i couldn't find any string to express since enum values are basically different. enum l1tf_mitigations seems more general like "off" or "on" doesn't dictate any special mitigation option. So the simplest way maybe is to print the string like "PTE inversion".

Maybe we should move the macro at top of the function so it can print it. This is the only information we can print about L1TF mitigation.

Regards
Khalid Ali

reviewer
#3 lore raw
In reply to Borislav Petkov
Quoted 25 lines · Borislav Petkov
Quoted 13 lines · Khalid Ali

Log the L1TF mitigation like other mitigatioons. This one is is the only one that doesn't get logged.

---
 arch/x86/kernel/cpu/bugs.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/bugs.c +0 -0
index 7f94e6a5497d..38cb2a1b2849 100644

arch/x86/kernel/cpu/bugs.c static void __init l1tf_apply_mitigation(void) · line 2808

Quoted 6 lines
arch/x86/kernel/cpu/bugs.c +1 -0
@@ -2803,6 +2803,7 @@ static void __init l1tf_apply_mitigation(void)
 		return;
 	}
 
+	pr_info("Mitigation: PTE inversion\n");
 	setup_force_cpu_cap(X86_FEATURE_L1TF_PTEINV);
 }

Pawan, what's the story here?

There's this stuff further down in that file:

Quoted 8 lines
| #define L1TF_DEFAULT_MSG "Mitigation: PTE Inversion"
|         
| #if IS_ENABLED(CONFIG_KVM_INTEL)
| static const char * const l1tf_vmx_states[] = {

which comes from 2018:

72c6d2db64fa ("x86/litf: Introduce vmx status variable")

I don't know the back story, but L1TF does have too many KVM specific modes. Probably thats why it is separate from the main mitigation. Also the KVM part can be compiled out for CONFIG_KVM=n (although it is not a common practice).

Quoted 2 lines

I guess it is about time we made this mitigation also follow the common pattern with the mitigation strings and issuing them at the right time?

I will try to combine the KVM part with the main mitigation.