cmd: smbios: Fix header for type 3 entries
PATCH 1/1 cmd: smbios: Fix header for type 3 entries
Change from "Baseboard Information" to "Chassis information".
Signed-off-by Mark Kettenis <[email protected]>
--- cmd/smbios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/smbios.c +1 -1
@@ -280,7 +280,7 @@ static void smbios_print_type3(struct smbios_type3 *table)int i;u8 *addr = (u8 *)table + offsetof(struct smbios_type3 , sku_number); -printf ("Baseboard Information\n" ); +printf ("Chassis Information\n" );smbios_print_str ("Manufacturer" , table, table->manufacturer);printf ("\tType: 0x%02x\n" , table->chassis_type);smbios_print_str ("Version" , table, table->version);
Signature · 1 line
2.49.0
Am 2. Juni 2025 22:10:08 MESZ schrieb Mark Kettenis <[email protected]>:
Quoted 3 lines
Change from "Baseboard Information" to "Chassis information".
Signed-off-by Mark Kettenis <[email protected]>
Shouldn't we replace all terms in the output with what we find in the SMBIOS specification?
E.g. the type 1 output should refer to "firmware" and not to "BIOS".
Reviewed-by Heinrich Schuchardt <[email protected]>
Quoted 17 lines
---
cmd/smbios.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)cmd/smbios.c +1
-1@@ -280,7 +280,7 @@ static void smbios_print_type3(struct smbios_type3 *table)int i;u8 *addr = (u8 *)table + offsetof(struct smbios_type3 , sku_number); -printf ("Baseboard Information\n" ); +printf ("Chassis Information\n" );smbios_print_str ("Manufacturer" , table, table->manufacturer);printf ("\tType: 0x%02x\n" , table->chassis_type);smbios_print_str ("Version" , table, table->version);
Quoted 3 lines · Mark Kettenis
Change from "Baseboard Information" to "Chassis information".
Applied to u-boot/next, thanks!
[1/1] cmd: smbios: Fix header for type 3 entries
commit: f35f053755f98e077389517f80ad7da81b031787
Signature · 1 line
Tom