t0200: replace 'test -d' with 'test_path_is_dir' and 'test -f' with 'test_path_is_file'
PATCH 1/1 t0200: replace 'test -d' with 'test_path_is_dir' and 'test -f' with 'test_path_is_file'
From: DerickWMFrias <[email protected]>
'test_path_is_file' and 'test_path_is_dir' are modern path checking methods in Git's development.
This patch replaces old 'test -d' and 'test -f' methods with them.
--- t/t0200-gettext-basic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
t/t0200-gettext-basic.sh +2 -2
@@ -31,12 +31,12 @@ test_expect_success 'xgettext sanity: Comment extraction with --add-comments sto ' test_expect_success GETTEXT 'sanity: $TEXTDOMAINDIR exists without NO_GETTEXT=YesPlease' ' - test -d "$TEXTDOMAINDIR" && + test_path_is_dir "$TEXTDOMAINDIR" && test "$TEXTDOMAINDIR" = "$GIT_TEXTDOMAINDIR" ' test_expect_success GETTEXT 'sanity: Icelandic locale was compiled' ' - test -f "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo" + test_path_is_file "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo" ' # TODO: When we have more locales, generalize this to test them
Signature · 1 line
2.49.0.634.g8613c2bb6c.dirty
Quoted 1 line · Derick W. de M. Frias
From: DerickWMFrias <[email protected]>
There is a mismatch between your name here (which would be applied as the patch author) and the Signed-off-by. These two should match.
Quoted 2 lines
'
test_path_is_file' and 'test_path_is_dir' are modern path checking methods in Git's development.
We typically want to provide enough context in commit messages to state _why_ the replacement is better. Them being more "modern" isn't yet a sufficiently good reason. So it would be great if we explicitly mention what the replacements bring to the table in a sentence or two.
Quoted 1 line
This patch replaces old 'test -d' and 'test -f' methods with them.
We use imperative style for commit messages, as if instructing the code to change. So instead of saying "This patch replaces", we'd say "Replace test -d and test -f ...".
The patch itself looks obviously good to me, thanks!
Patrick
PATCH v2 1/1 t0200: replace 'test -d' with 'test_path_is_dir' and 'test -f' with 'test_path_is_file'
Thanks for your feedback Patrick. I'm resending the patch with your suggestions.
'test_path_is_file' and 'test_path_is_dir' are modern debbuging-friendly path checking methods in Git's development that output useful messages when the test fails, unlike 'test -f' and 'test -d' that don't provide feedback.
Replace 'test -d' and 'test -f' methods with 'test_path_is_dir' and 'test_path_is_file'.
--- t/t0200-gettext-basic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
t/t0200-gettext-basic.sh +2 -2
@@ -31,12 +31,12 @@ test_expect_success 'xgettext sanity: Comment extraction with --add-comments sto ' test_expect_success GETTEXT 'sanity: $TEXTDOMAINDIR exists without NO_GETTEXT=YesPlease' ' - test -d "$TEXTDOMAINDIR" && + test_path_is_dir "$TEXTDOMAINDIR" && test "$TEXTDOMAINDIR" = "$GIT_TEXTDOMAINDIR" ' test_expect_success GETTEXT 'sanity: Icelandic locale was compiled' ' - test -f "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo" + test_path_is_file "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo" ' # TODO: When we have more locales, generalize this to test them
Signature · 1 line
2.50.0.rc0.62.g658f0ae201.dirty