Skip to contentSkip to conversation

x86: Delete split IRQ chip variants of apic and ioapic tests

PATCH Applied Sean Christopherson 2 participants 3 messages Jun 4, 2025 – Jun 11, 2025 KVM

lore
Share & tools
lore

Sean Christopherson

author reviewer
#0 lore raw

PATCH 1/1 x86: Delete split IRQ chip variants of apic and ioapic tests

Remove the dedicated {io,}apic-split testcases and instead rely on users to run KVM-Unit-Tests with ACCEL="kvm,kernel_irqchip=split" to provide the desired coverage.

While providing more coverage by "default" is nice, the flip side of doing so is that makes it annoying for an end user to do more, and gives the false impression that the configurations in unittests.cfg are the only configurations worth testing.

E.g. with kernel_irqchip=split, svm_npt fails on x2AVIC hardware due to test bugs, hyperv_connections fails due to what is effectively a QEMU bug that also got hoisted into KVM], and vmx_apic_passthrough_tpr_threshold_test fails (with some KVM versions) due to a KVM bug that happened to be masked by another KVM bug with the in-kernel PIT emulation.

---
 x86/unittests.cfg | 13 -------------
 1 file changed, 13 deletions(-)
x86/unittests.cfg +0 -13
index 6e69c50b..4f06a59f 100644
@@ -7,19 +7,6 @@
 # arch = i386|x86_64
 ##############################################################################
 
-[apic-split]
-file = apic.flat
-smp = 2
-extra_params = -cpu qemu64,+x2apic,+tsc-deadline -machine kernel_irqchip=split
-arch = x86_64
-groups = apic
-
-[ioapic-split]
-file = ioapic.flat
-extra_params = -cpu qemu64 -machine kernel_irqchip=split
-arch = x86_64
-groups = apic
-
 [x2apic]
 file = apic.flat
 smp = 2

base-commit: 72d110d8286baf1b355301cc8c8bdb42be2663fb

Signature · 1 line
2.49.0.1204.g71687c7c1d-goog
author reviewer Applied
#1 lore raw
Quoted 10 lines · Sean Christopherson

Remove the dedicated {io,}apic-split testcases and instead rely on users to run KVM-Unit-Tests with ACCEL="kvm,kernel_irqchip=split" to provide the desired coverage.

While providing more coverage by "default" is nice, the flip side of doing so is that makes it annoying for an end user to do more, and gives the false impression that the configurations in unittests.cfg are the only configurations worth testing.

[...]

Applied to kvm-x86 next, thanks!

[1/1] x86: Delete split IRQ chip variants of apic and ioapic tests

      https://github.com/kvm-x86/kvm-unit-tests/commit/0293b912a7e7

--
https://github.com/kvm-x86/kvm-unit-tests/tree/next

Acked-by on v1 1/1
#2 lore raw
In reply to Sean Christopherson
Quoted 8 lines · Sean Christopherson

Remove the dedicated {io,}apic-split testcases and instead rely on users to run KVM-Unit-Tests with ACCEL="kvm,kernel_irqchip=split" to provide the desired coverage.

While providing more coverage by "default" is nice, the flip side of doing so is that makes it annoying for an end user to do more, and gives the false impression that the configurations in unittests.cfg are the only configurations worth testing.

Got it, thanks for the patch!

Quoted 7 lines

E.g. with kernel_irqchip=split, svm_npt fails on x2AVIC hardware due to test bugs, hyperv_connections fails due to what is effectively a QEMU bug that also got hoisted into KVM], and vmx_apic_passthrough_tpr_threshold_test fails (with some KVM versions) due to a KVM bug that happened to be masked by another KVM bug with the in-kernel PIT emulation.

Quoted 8 lines
---
 x86/unittests.cfg | 13 -------------
 1 file changed, 13 deletions(-)

I know you have pulled this already, but FWIW:

- Naveen