Skip to contentSkip to conversation

selftests: drv-net: tso: fix the GRE device name

PATCH Applied Jakub Kicinski 4 participants 4 messages Jun 4, 2025 – Jun 5, 2025

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 selftests: drv-net: tso: fix the GRE device name

The device type for IPv4 GRE is "gre" not "ipgre", unlike for IPv6 which uses "ip6gre".

Not sure how I missed this when writing the test, perhaps because all HW I have access to is on an IPv6-only network.

Fixes 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")

---
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/testing/selftests/drivers/net/hw/tso.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/drivers/net/hw/tso.py +1 -1
index 150d6db241a0..3370827409aa 100755
@@ -216,7 +216,7 @@ from lib.py import bkg, cmd, defer, ethtool, ip, rand_port, wait_port_listen
             ("",            "6", "tx-tcp6-segmentation",          None),
             ("vxlan",        "", "tx-udp_tnl-segmentation",       ("vxlan",  True,  "id 100 dstport 4789 noudpcsum")),
             ("vxlan_csum",   "", "tx-udp_tnl-csum-segmentation",  ("vxlan",  False, "id 100 dstport 4789 udpcsum")),
-            ("gre",         "4", "tx-gre-segmentation",           ("ipgre",  False,  "")),
+            ("gre",         "4", "tx-gre-segmentation",           ("gre",    False,  "")),
             ("gre",         "6", "tx-gre-segmentation",           ("ip6gre", False,  "")),
         )
 
Signature · 1 line
2.49.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jakub Kicinski

The device type for IPv4 GRE is "gre" not "ipgre", unlike for IPv6 which uses "ip6gre".

Not sure how I missed this when writing the test, perhaps because all HW I have access to is on an IPv6-only network.

Fixes 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")
#3 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Tue, 3 Jun 2025 18:20:31 -0700 you wrote:

The device type for IPv4 GRE is "gre" not "ipgre", unlike for IPv6 which uses "ip6gre".

Not sure how I missed this when writing the test, perhaps because all HW I have access to is on an IPv6-only network.

Fixes 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")

[...]

Here is the summary with links:
- [net] selftests: drv-net: tso: fix the GRE device name

    https://git.kernel.org/netdev/net/c/c68804c934e3

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html