Netfilter fix for -stable
Subsystems (2)
Pablo Neira Ayuso
maintainercover Netfilter fix for -stable
Hi Greg, Sasha,
This batch contains backported fixes for 5.10 -stable.
The following list shows the backported patch, I am using original commit IDs for reference:
1) 8b26ff7af8c3 ("netfilter: nft_socket: fix sk refcount leaks")
This is to fix a sk memleak, backport patch posted by Denis Arefev.
Please, apply,
Thanks
Florian Westphal (1):
netfilter: nft_socket: fix sk refcount leaks
net/netfilter/nft_socket.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.30.2
Pablo Neira Ayuso
maintainerPATCH 1/1 netfilter: nft_socket: fix sk refcount leaks
From: Florian Westphal <[email protected]>
commit 8b26ff7af8c32cb4148b3e147c52f9e4c695209c upstream.
We must put 'sk' reference before returning.
Fixes 039b1f4f24ec ("netfilter: nft_socket: fix erroneous socket assignment")
Signed-off-by Florian Westphal <[email protected]>
Signed-off-by Pablo Neira Ayuso <[email protected]>
---
Backport patch posted by Denis Arefev.
net/netfilter/nft_socket.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
net/netfilter/nft_socket.c +3 -2
@@ -88,13 +88,13 @@ static void nft_socket_eval(const struct nft_expr *expr, *dest = sk->sk_mark; }else { regs->verdict.code =NFT_BREAK ; -return ; + goto out_put_sk; }break ;case NFT_SOCKET_WILDCARD :if (!sk_fullsock (sk)) { regs->verdict.code =NFT_BREAK ; -return ; + goto out_put_sk; }nft_socket_wildcard (pkt, regs, sk, dest);break ;
@@ -103,6 +103,7 @@ static void nft_socket_eval(const struct nft_expr *expr, regs->verdict.code =NFT_BREAK ; } +out_put_sk:if (sk != skb->sk)sock_gen_put (sk); }
Signature · 1 line
2.30.2