Skip to contentSkip to conversation

net: enetc: fix the netc-lib driver build dependency

PATCH Applied Wei Fang 3 participants 5 messages Jun 5, 2025 – Jun 6, 2025

Subsystems (4)
lore
Share & tools
lore

Wei Fang

author maintainer
#0 lore raw

PATCH v2 1/1 net: enetc: fix the netc-lib driver build dependency

The kernel robot reported the following errors when the netc-lib driver was compiled as a loadable module and the enetc-core driver was built-in.

ld.lld: error: undefined symbol: ntmp_init_cbdr
referenced by enetc_cbdr.c:88 (drivers/net/ethernet/freescale/enetc/enetc_cbdr.c:88) ld.lld: error: undefined symbol: ntmp_free_cbdr
referenced by enetc_cbdr.c:96 (drivers/net/ethernet/freescale/enetc/enetc_cbdr.c:96)

Simply changing "tristate" to "bool" can fix this issue, but considering that the netc-lib driver needs to support being compiled as a loadable module and LS1028 does not need the netc-lib driver. Therefore, we add a boolean symbol 'NXP_NTMP' to enable 'NXP_NETC_LIB' as needed. And when adding NETC switch driver support in the future, there is no need to modify the dependency, just select "NXP_NTMP" and "NXP_NETC_LIB" at the same time.

Fixes 4701073c3deb ("net: enetc: add initial netc-lib driver to support NTMP")

---
v1 Link: https://lore.kernel.org/imx/[email protected]/
v2:
1. Add the boolean symbol 'NXP_NTMP' as Arnd suggested and modify the commit message.

---
 drivers/net/ethernet/freescale/enetc/Kconfig | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/net/ethernet/freescale/enetc/Kconfig +5 -1
index e917132d3714..54b0f0a5a6bb 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 config FSL_ENETC_CORE
 	tristate
+	select NXP_NETC_LIB if NXP_NTMP
 	help
 	  This module supports common functionality between the PF and VF
 	  drivers for the NXP ENETC controller.
@@ -22,6 +23,9 @@ config NXP_NETC_LIB
 	  Switch, such as NETC Table Management Protocol (NTMP) 2.0, common tc
 	  flower and debugfs interfaces and so on.
 
+config NXP_NTMP
+	bool
+
 config FSL_ENETC
 	tristate "ENETC PF driver"
 	depends on PCI_MSI
@@ -45,7 +49,7 @@ config NXP_ENETC4
 	select FSL_ENETC_CORE
 	select FSL_ENETC_MDIO
 	select NXP_ENETC_PF_COMMON
-	select NXP_NETC_LIB
+	select NXP_NTMP
 	select PHYLINK
 	select DIMLIB
 	help
Signature · 1 line
2.34.1
maintainer
#1 lore raw

Hi Wei,

Quoted 65 lines · Wei Fang

The kernel robot reported the following errors when the netc-lib driver was compiled as a loadable module and the enetc-core driver was built-in.

ld.lld: error: undefined symbol: ntmp_init_cbdr
referenced by enetc_cbdr.c:88 (drivers/net/ethernet/freescale/enetc/enetc_cbdr.c:88) ld.lld: error: undefined symbol: ntmp_free_cbdr
referenced by enetc_cbdr.c:96 (drivers/net/ethernet/freescale/enetc/enetc_cbdr.c:96)

Simply changing "tristate" to "bool" can fix this issue, but considering that the netc-lib driver needs to support being compiled as a loadable module and LS1028 does not need the netc-lib driver. Therefore, we add a boolean symbol 'NXP_NTMP' to enable 'NXP_NETC_LIB' as needed. And when adding NETC switch driver support in the future, there is no need to modify the dependency, just select "NXP_NTMP" and "NXP_NETC_LIB" at the same time.

Fixes 4701073c3deb ("net: enetc: add initial netc-lib driver to support NTMP")

---
v1 Link: https://lore.kernel.org/imx/[email protected]/
v2:
1. Add the boolean symbol 'NXP_NTMP' as Arnd suggested and modify the commit message.

---
 drivers/net/ethernet/freescale/enetc/Kconfig | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/net/ethernet/freescale/enetc/Kconfig +5 -1
index e917132d3714..54b0f0a5a6bb 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 config FSL_ENETC_CORE
 	tristate
+	select NXP_NETC_LIB if NXP_NTMP
 	help
 	  This module supports common functionality between the PF and VF
 	  drivers for the NXP ENETC controller.
@@ -22,6 +23,9 @@ config NXP_NETC_LIB
 	  Switch, such as NETC Table Management Protocol (NTMP) 2.0, common tc
 	  flower and debugfs interfaces and so on.
 
+config NXP_NTMP
+	bool
+
 config FSL_ENETC
 	tristate "ENETC PF driver"
 	depends on PCI_MSI
@@ -45,7 +49,7 @@ config NXP_ENETC4
 	select FSL_ENETC_CORE
 	select FSL_ENETC_MDIO
 	select NXP_ENETC_PF_COMMON
-	select NXP_NETC_LIB
+	select NXP_NTMP
 	select PHYLINK
 	select DIMLIB
 	help
Signature · 1 line
2.34.1

I think you slightly misunderstood Arnd's suggestion. NXP_NTMP was named "NXP_NETC_NTMP" in his proposal, and it meant "does FSL_ENETC_CORE need the functionality from NXP_NETC_LIB?".

The switch driver shouldn't need to select NXP_NTMP. Just NXP_NETC_LIB.

I don't agree with removing "NETC" from NXP_NETC_NTMP, I think it helps clarify that the option pertains just to the NETC drivers.

author maintainer
#2 lore raw
Quoted 79 lines · Wei Fang
Quoted 2 lines

The kernel robot reported the following errors when the netc-lib driver was compiled as a loadable module and the enetc-core driver was

built-in.

Quoted 19 lines

ld.lld: error: undefined symbol: ntmp_init_cbdr referenced by enetc_cbdr.c:88 (drivers/net/ethernet/freescale/enetc/enetc_cbdr.c:88) ld.lld: error: undefined symbol: ntmp_free_cbdr referenced by enetc_cbdr.c:96 (drivers/net/ethernet/freescale/enetc/enetc_cbdr.c:96)

Simply changing "tristate" to "bool" can fix this issue, but considering that the netc-lib driver needs to support being compiled as a loadable module and LS1028 does not need the netc-lib driver. Therefore, we add a boolean symbol 'NXP_NTMP' to enable 'NXP_NETC_LIB' as needed. And when adding NETC switch driver support in the future, there is no need to modify the dependency, just select "NXP_NTMP" and "NXP_NETC_LIB" at the same time.

Closes:
https://lore.kernel.org/oe-kbuild-all/202505220734.x6TF6oHR-lkp@intel.
com/

Quoted 7 lines
Fixes 4701073c3deb ("net: enetc: add initial netc-lib driver to

support NTMP")

---
v1 Link:

https://lore.kernel.org/imx/[email protected]/

Quoted 21 lines

v2:
1. Add the boolean symbol 'NXP_NTMP' as Arnd suggested and modify the commit message.

---
 drivers/net/ethernet/freescale/enetc/Kconfig | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/net/ethernet/freescale/enetc/Kconfig +1 -0
index e917132d3714..54b0f0a5a6bb 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 config FSL_ENETC_CORE
 	tristate
+	select NXP_NETC_LIB if NXP_NTMP
 	help
 	  This module supports common functionality between the PF and VF
 	  drivers for the NXP ENETC controller.

drivers/net/ethernet/freescale/enetc/Kconfig config NXP_NETC_LIB · line 23

Quoted 1 line
drivers/net/ethernet/freescale/enetc/Kconfig +0 -0
@@ -22,6 +23,9 @@ config NXP_NETC_LIB
 	  Switch, such as NETC Table Management Protocol (NTMP) 2.0, common

tc

Quoted 18 lines
drivers/net/ethernet/freescale/enetc/Kconfig +4 -2
 	  flower and debugfs interfaces and so on.
 
+config NXP_NTMP
+	bool
+
 config FSL_ENETC
 	tristate "ENETC PF driver"
 	depends on PCI_MSI
@@ -45,7 +49,7 @@ config NXP_ENETC4
 	select FSL_ENETC_CORE
 	select FSL_ENETC_MDIO
 	select NXP_ENETC_PF_COMMON
-	select NXP_NETC_LIB
+	select NXP_NTMP
 	select PHYLINK
 	select DIMLIB
 	help
--
Quoted 2 lines

2.34.1

I think you slightly misunderstood Arnd's suggestion. NXP_NTMP was named "NXP_NETC_NTMP" in his proposal, and it meant "does FSL_ENETC_CORE need the functionality from NXP_NETC_LIB?".

Quoted 2 lines

The switch driver shouldn't need to select NXP_NTMP. Just NXP_NETC_LIB.

For the case :NXP_ENET4=n , FSL_ENETC=y and NXP_NETC_SWITCH=m, if the switch driver only selects NXP_NETC_LIB, then the netc-lib driver will be compiled as a module. So the issue will be reported again. And Arnd also said "The switch module can then equally enable bool symbol."

Quoted 2 lines

I don't agree with removing "NETC" from NXP_NETC_NTMP, I think it helps clarify that the option pertains just to the NETC drivers.

NTMP means " NETC Table Management Protocol", I don't know why we need to add a 'NETC' again, it does not make sense to me.

maintainer Reviewed-by
#3 lore raw
Quoted 12 lines · Wei Fang
Quoted 6 lines

I think you slightly misunderstood Arnd's suggestion. NXP_NTMP was named "NXP_NETC_NTMP" in his proposal, and it meant "does FSL_ENETC_CORE need the functionality from NXP_NETC_LIB?".

The switch driver shouldn't need to select NXP_NTMP. Just NXP_NETC_LIB.

For the case :NXP_ENET4=n , FSL_ENETC=y and NXP_NETC_SWITCH=m, if the switch driver only selects NXP_NETC_LIB, then the netc-lib driver will be compiled as a module. So the issue will be reported again. And Arnd also said "The switch module can then equally enable bool symbol."

Quoted 5 lines
Quoted 2 lines

I don't agree with removing "NETC" from NXP_NETC_NTMP, I think it helps clarify that the option pertains just to the NETC drivers.

NTMP means " NETC Table Management Protocol", I don't know why we need to add a 'NETC' again, it does not make sense to me.

Understood, thanks for the example. It was me who misunderstood. In that case

#4 lore raw
In reply to Wei Fang
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 9 lines · On Thu, 5 Jun 2025 14:08:36 +0800 you wrote:

The kernel robot reported the following errors when the netc-lib driver was compiled as a loadable module and the enetc-core driver was built-in.

ld.lld: error: undefined symbol: ntmp_init_cbdr
referenced by enetc_cbdr.c:88 (drivers/net/ethernet/freescale/enetc/enetc_cbdr.c:88) ld.lld: error: undefined symbol: ntmp_free_cbdr
referenced by enetc_cbdr.c:96 (drivers/net/ethernet/freescale/enetc/enetc_cbdr.c:96)

[...]

Here is the summary with links:
- [v2] net: enetc: fix the netc-lib driver build dependency

    https://git.kernel.org/netdev/net/c/82cbd06f327f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html