vhost: fix net control virtqueue used length
PATCH 1/1 vhost: fix net control virtqueue used length
By the standard this is the number of bytes written.
Fixes 474f4d7840ad ("vhost: add control virtqueue")
Signed-off-by Eugenio Pérez <[email protected]>
--- lib/vhost/virtio_net_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/vhost/virtio_net_ctrl.c +1 -1
@@ -229,7 +229,7 @@ virtio_net_ctrl_push(struct virtio_net *dev, struct virtio_net_ctrl_elem *ctrl_e used_elem = &cvq->used->ring[cvq->last_used_idx & (cvq->size -1 )]; used_elem->id = ctrl_elem->head_idx; - used_elem->len = ctrl_elem->n_descs; + used_elem->len =sizeof (*ctrl_elem->desc_ack); cvq->last_used_idx++;
Signature · 1 line
2.49.0
Quoted 15 lines · Eugenio Pérez
By the standard this is the number of bytes written.
Fixes 474f4d7840ad ("vhost: add control virtqueue")Signed-off-by Eugenio Pérez <[email protected]>--- lib/vhost/virtio_net_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/vhost/virtio_net_ctrl.c +0
-0
lib/vhost/virtio_net_ctrl.c virtio_net_ctrl_push(struct virtio_net *dev, struct virtio_net_ctrl_elem *ctrl_e · line 235
Quoted 8 lines
lib/vhost/virtio_net_ctrl.c +1
-1@@ -229,7 +229,7 @@ virtio_net_ctrl_push(struct virtio_net *dev, struct virtio_net_ctrl_elem *ctrl_e used_elem = &cvq->used->ring[cvq->last_used_idx & (cvq->size -1 )]; used_elem->id = ctrl_elem->head_idx; - used_elem->len = ctrl_elem->n_descs; + used_elem->len =sizeof (*ctrl_elem->desc_ack); cvq->last_used_idx++;
Reviewed-by Maxime Coquelin <[email protected]>
Thanks,
Maxime
Maxime Coquelin
AppliedQuoted 15 lines · Eugenio Pérez
By the standard this is the number of bytes written.
Fixes 474f4d7840ad ("vhost: add control virtqueue")Signed-off-by Eugenio Pérez <[email protected]>--- lib/vhost/virtio_net_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/vhost/virtio_net_ctrl.c +0
-0
lib/vhost/virtio_net_ctrl.c virtio_net_ctrl_push(struct virtio_net *dev, struct virtio_net_ctrl_elem *ctrl_e · line 235
Quoted 8 lines
lib/vhost/virtio_net_ctrl.c +1
-1@@ -229,7 +229,7 @@ virtio_net_ctrl_push(struct virtio_net *dev, struct virtio_net_ctrl_elem *ctrl_e used_elem = &cvq->used->ring[cvq->last_used_idx & (cvq->size -1 )]; used_elem->id = ctrl_elem->head_idx; - used_elem->len = ctrl_elem->n_descs; + used_elem->len =sizeof (*ctrl_elem->desc_ack); cvq->last_used_idx++;
Applied to next-virtio/for-net-next.
Thanks,
Maxime