Skip to contentSkip to conversation

btrfs: update comment for fields in btrfs_root

PATCH In review Sun YangKai 3 participants 3 messages Jun 4, 2025 – Jun 5, 2025 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs: update comment for fields in btrfs_root

The inode_lock field of struct btrfs_root was removed in
commit e2844cce75c9e61("btrfs: remove inode_lock from struct btrfs_root and use xarray locks") but the related comment is not updated.

---
 fs/btrfs/ctree.h | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
fs/btrfs/ctree.h +2 -8
index 71fa42ca04fe..9dfe2dcd4a37 100644
@@ -224,16 +224,10 @@ struct btrfs_root {
 
 	struct list_head root_list;
 
-	/*
-	 * Xarray that keeps track of in-memory inodes, protected by the lock
-	 * @inode_lock.
-	 */
+	/* Xarray that keeps track of in-memory inodes. */
 	struct xarray inodes;
 
-	/*
-	 * Xarray that keeps track of delayed nodes of every inode, protected
-	 * by @inode_lock.
-	 */
+	/* Xarray that keeps track of delayed nodes of every inode. */
 	struct xarray delayed_nodes;
 	/*
 	 * right now this just gets used so that a root has its own devid
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Sun YangKai

The inode_lock field of struct btrfs_root was removed in
commit e2844cce75c9e61("btrfs: remove inode_lock from struct btrfs_root and use xarray locks") but the related comment is not updated.

Looks good, thanks.

Quoted 31 lines
---
 fs/btrfs/ctree.h | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
fs/btrfs/ctree.h +2 -9
index 71fa42ca04fe..9dfe2dcd4a37 100644
@@ -224,16 +224,10 @@ struct btrfs_root {
 
        struct list_head root_list;
 
-       /*
-        * Xarray that keeps track of in-memory inodes, protected by the lock
-        * @inode_lock.
-        */
+       /* Xarray that keeps track of in-memory inodes. */
        struct xarray inodes;
 
-       /*
-        * Xarray that keeps track of delayed nodes of every inode, protected
-        * by @inode_lock.
-        */
+       /* Xarray that keeps track of delayed nodes of every inode. */
        struct xarray delayed_nodes;
        /*
         * right now this just gets used so that a root has its own devid
--

2.49.0