tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Subsystems (2)
PATCH 1/1 tools/resolve_btfids: Fix build when cross compiling kernel with clang.
When cross compiling the kernel with clang, we need to override CLANG_CROSS_FLAGS when preparing the step libraries for resolve_btfids.
Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it.
--- tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/bpf/resolve_btfids/Makefile +1 -1
@@ -17,7 +17,7 @@ endif # Overrides for the prepare step libraries. HOST_OVERRIDES := AR="$(HOSTAR)" CC="$(HOSTCC)" LD="$(HOSTLD)" ARCH="$(HOSTARCH)" \ - CROSS_COMPILE="" EXTRA_CFLAGS="$(HOSTCFLAGS)" + CROSS_COMPILE="" CLANG_CROSS_FLAGS="" EXTRA_CFLAGS="$(HOSTCFLAGS)" RM ?= rm HOSTCC ?= gcc
Signature · 1 line
2.50.0.rc0.642.g800a2b2222-goog
PATCH RESEND 1/1 tools/resolve_btfids: Fix build when cross compiling kernel with clang.
When cross compiling the kernel with clang, we need to override CLANG_CROSS_FLAGS when preparing the step libraries for resolve_btfids.
Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it.
--- tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/bpf/resolve_btfids/Makefile +1 -1
@@ -17,7 +17,7 @@ endif # Overrides for the prepare step libraries. HOST_OVERRIDES := AR="$(HOSTAR)" CC="$(HOSTCC)" LD="$(HOSTLD)" ARCH="$(HOSTARCH)" \ - CROSS_COMPILE="" EXTRA_CFLAGS="$(HOSTCFLAGS)" + CROSS_COMPILE="" CLANG_CROSS_FLAGS="" EXTRA_CFLAGS="$(HOSTCFLAGS)" RM ?= rm HOSTCC ?= gcc
Signature · 1 line
2.50.0.rc0.642.g800a2b2222-goog
Greg KH
maintainerQuoted 9 lines · Suleiman Souhlal
When cross compiling the kernel with clang, we need to override
CLANG_CROSS_FLAGSwhen preparing the step libraries forresolve_btfids.Prior to commit
d1d096312176("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value forCLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it.
Quoted 6 lines
Fixes 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")Signed-off-by Suleiman Souhlal <[email protected]>--- tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
You forgot to say why this is a resend :(
Quoted 11 lines · Greg KH
Quoted 9 lines · Suleiman Souhlal
When cross compiling the kernel with clang, we need to override
CLANG_CROSS_FLAGSwhen preparing the step libraries forresolve_btfids.Prior to commit
d1d096312176("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value forCLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it.
Quoted 8 lines
Quoted 6 lines
Fixes 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")Signed-off-by Suleiman Souhlal <[email protected]>--- tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)You forgot to say why this is a resend :(
I wasn't sure how to say it. It didn't occur to me that I could have replied to it with the reason.
It was because I had "Signed-of-by:" instead of "Signed-off-by:".
-- Suleiman
Greg KH
maintainerQuoted 19 lines · Suleiman Souhlal
Quoted 18 lines · Greg KH
Quoted 15 lines · Suleiman Souhlal
When cross compiling the kernel with clang, we need to override
CLANG_CROSS_FLAGSwhen preparing the step libraries forresolve_btfids.Prior to commit
d1d096312176("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value forCLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it.Fixes 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")Signed-off-by Suleiman Souhlal <[email protected]>--- tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines
Quoted 1 line
You forgot to say why this is a resend :(
I wasn't sure how to say it. It didn't occur to me that I could have replied to it with the reason.
That goes below the --- line and it would be a v2, not a RESEND as you changed something:
Quoted 1 line
It was because I had "Signed-of-by:" instead of "Signed-off-by:".
Which means it was not identical to the first version (a RESEND means a maintainer can take either as they are the same).
thanks,
greg k-h
Quoted 26 lines · Greg KH
Quoted 19 lines · Suleiman Souhlal
Quoted 18 lines · Greg KH
Quoted 15 lines · Suleiman Souhlal
When cross compiling the kernel with clang, we need to override
CLANG_CROSS_FLAGSwhen preparing the step libraries forresolve_btfids.Prior to commit
d1d096312176("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value forCLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it.Fixes 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")Signed-off-by Suleiman Souhlal <[email protected]>--- tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 4 lines
Quoted 1 line
You forgot to say why this is a resend :(
I wasn't sure how to say it. It didn't occur to me that I could have replied to it with the reason.
Quoted 7 lines
That goes below the --- line and it would be a v2, not a RESEND as you changed something:
Quoted 1 line
It was because I had "Signed-of-by:" instead of "Signed-off-by:".
Which means it was not identical to the first version (a RESEND means a maintainer can take either as they are the same).
Ah. Should I resend it as a v2?
Thanks,
-- Suleiman
Greg KH
maintainerQuoted 30 lines · Suleiman Souhlal
Quoted 29 lines · Greg KH
Quoted 19 lines · Suleiman Souhlal
Quoted 18 lines · Greg KH
Quoted 15 lines · Suleiman Souhlal
When cross compiling the kernel with clang, we need to override
CLANG_CROSS_FLAGSwhen preparing the step libraries forresolve_btfids.Prior to commit
d1d096312176("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value forCLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it.Fixes 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")Signed-off-by Suleiman Souhlal <[email protected]>--- tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 4 lines
Quoted 1 line
You forgot to say why this is a resend :(
I wasn't sure how to say it. It didn't occur to me that I could have replied to it with the reason.
That goes below the --- line and it would be a v2, not a RESEND as you changed something:
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
It was because I had "Signed-of-by:" instead of "Signed-off-by:".
Which means it was not identical to the first version (a RESEND means a maintainer can take either as they are the same).
Ah. Should I resend it as a v2?
Think about what you would want to see if you were on the recieving end of thousands of patches and had to try to figure out what to ignore and what to pay attention to...
thanks,
greg k-h