package/libcurl: fix build w/ threads + c-ares
PATCH 1/1 package/libcurl: fix build w/ threads + c-ares
Fixes:
https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/
Since curl 8.14.0 with commit d364f1347f05 ("configure: catch asking for double resolver without https-rr"), configure errors out when --enabled-threaded-resolver is used together with --enable-ares (unless the experimental HTTPS-RR support is enabled), so disable the threaded resolver when c-ares is enabled.
https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
--- package/libcurl/libcurl.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
package/libcurl/libcurl.mk +3 -1
@@ -36,7 +36,9 @@ LIBCURL_CONF_OPTS = \ # https://nvd.nist.gov/vuln/detail/CVE-2024-32928 LIBCURL_IGNORE_CVES += CVE-2024-32928 -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) +# threaded resolver cannot be used with c-ares +# https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8 +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS)x$(BR2_PACKAGE_C_ARES)),yx) LIBCURL_CONF_OPTS += --enable-threaded-resolver else LIBCURL_CONF_OPTS += --disable-threaded-resolver
Signature · 6 lines
2.39.5 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Peter,
Quoted 9 lines · Peter Korsgaard
Fixes:
https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/Since curl 8.14.0 with commit
d364f1347f05("configure: catch asking for double resolver without https-rr"), configure errors out when --enabled-threaded-resolver is used together with --enable-ares (unless the experimental HTTPS-RR support is enabled), so disable the threaded resolver when c-ares is enabled.
Quoted 3 lines
https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
Signed-off-by Peter Korsgaard <[email protected]>
Thanks,
baruch
Quoted 19 lines
--- package/libcurl/libcurl.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)package/libcurl/libcurl.mk +3
-1@@ -36,7 +36,9 @@ LIBCURL_CONF_OPTS = \ # https://nvd.nist.gov/vuln/detail/CVE-2024-32928 LIBCURL_IGNORE_CVES += CVE-2024-32928 -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) +# threaded resolver cannot be used with c-ares +# https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8 +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS)x$(BR2_PACKAGE_C_ARES)),yx) LIBCURL_CONF_OPTS += --enable-threaded-resolver else LIBCURL_CONF_OPTS += --disable-threaded-resolver
Signature · 7 lines
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildrootQuoted 10 lines · Peter Korsgaard via buildroot
Fixes:
https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/Since curl 8.14.0 with commit
d364f1347f05("configure: catch asking for double resolver without https-rr"), configure errors out when --enabled-threaded-resolver is used together with --enable-ares (unless the
experimental HTTPS-RR support is enabled), so disable the threaded resolver when c-ares is enabled.
Quoted 3 lines
https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 9 lines · Peter Korsgaard via buildroot
Fixes:
https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/Since curl 8.14.0 with commit
d364f1347f05("configure: catch asking for double resolver without https-rr"), configure errors out when --enabled-threaded-resolver is used together with --enable-ares (unless the experimental HTTPS-RR support is enabled), so disable the threaded resolver when c-ares is enabled.
Quoted 3 lines
https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
Signed-off-by Peter Korsgaard <[email protected]>
Applied to 2025.02.x, thanks.
Regards,
Arnout
Quoted 9 lines
--- package/libcurl/libcurl.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)package/libcurl/libcurl.mk +0
-0
package/libcurl/libcurl.mk LIBCURL_CONF_OPTS = \ · line 44
Quoted 10 lines
package/libcurl/libcurl.mk +3
-1@@ -36,7 +36,9 @@ LIBCURL_CONF_OPTS = \ # https://nvd.nist.gov/vuln/detail/CVE-2024-32928 LIBCURL_IGNORE_CVES += CVE-2024-32928 -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) +# threaded resolver cannot be used with c-ares +# https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8 +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS)x$(BR2_PACKAGE_C_ARES)),yx) LIBCURL_CONF_OPTS += --enable-threaded-resolver else LIBCURL_CONF_OPTS += --disable-threaded-resolver
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot