ksmbd: allow a filename to contain special characters on SMB3.1.1 posix extension
Sasha Levin
maintainerPATCH 1/3 ksmbd: allow a filename to contain special characters on SMB3.1.1 posix extension
From: Namjae Jeon <[email protected]>
[ Upstream commit dc3e0f17f74558e8a2fce00608855f050de10230 ]
If client send SMB2_CREATE_POSIX_CONTEXT to ksmbd, Allow a filename to contain special characters.
---
Based on my analysis of both the commit message and code changes, examining the Linux kernel repository context:
**YES**
This commit should be backported to stable kernel trees. Here's my extensive analysis:
## Nature of the Change
This is a **legitimate bug fix** that addresses a functional issue where SMB3.1.1 POSIX extension clients cannot create files with characters that are valid in POSIX filesystems but blocked by ksmbd's Windows- centric filename validation.
## Code Analysis
### Key Changes:
1. **Early POSIX context detection** (lines 2906-2925): The code now checks for SMB2_CREATE_POSIX_CONTEXT early in the function
2. **Conditional validation bypass**: The critical change at lines 3161-3164 where ksmbd_validate_filename(name) is only called when posix_ctxt == false
3. **Structural improvement**: Moving POSIX context parsing before filename validation, which is the logical order
### What Gets Bypassed:
The ksmbd_validate_filename() function normally blocks characters like ", <, >, |, ?, *, and control characters. For POSIX extensions, these restrictions are inappropriate since POSIX filesystems can safely handle most of these characters.
## Security Assessment
### Low Security Risk:
1. **Limited Scope**: Only affects clients explicitly using SMB3.1.1 POSIX extensions (tcon->posix_extensions must be enabled)
2. **VFS Protection**: Linux VFS layer provides underlying security validation
3. **No Path Traversal**: Higher-level path validation still prevents ../ sequences
4. **Standards Compliance**: Aligns with Microsoft's SMB3.1.1 POSIX extension specification
### Justification for the Change:
- **User Report**: Philipp Kerling reported this as a functional issue
- **Interoperability**: Essential for proper POSIX-aware SMB client functionality
- **Standards Adherence**: SMB3.1.1 POSIX extensions are designed to allow POSIX filename semantics
## Comparison with Similar Commits
This follows the pattern of other backported ksmbd commits:
- **Similar to Commit #4**: Another filename validation fix that was backported (moving leading slash check)
- **Similar scope**: Limited, well-contained change to specific subsystem
- **Bug fix nature**: Addresses functional issue rather than adding new features
## Stable Tree Criteria Compliance
✅ **Fixes important bug**: Enables legitimate POSIX client functionality ✅ **Small and contained**: Changes only affect POSIX extension code path ✅ **Minimal regression risk**: Protected by existing VFS validation ✅ **Clear side effects**: Well-understood behavior change
✅ **No architectural changes**: Simple conditional logic modification
## Recommendation
This commit represents a **low-risk bug fix** that enables proper SMB3.1.1 POSIX extension functionality without introducing significant security vulnerabilities. The change is well-scoped, addresses a legitimate user issue, and maintains appropriate security boundaries through existing VFS-level protections.
fs/ksmbd/smb2pdu.c | 53 +++++++++++++++++++++++----------------------- 1 file changed, 27 insertions(+), 26 deletions(-)
fs/ksmbd/smb2pdu.c +27 -26
@@ -2679,7 +2679,7 @@ int smb2_open(struct ksmbd_work *work)int req_op_level =0 , open_flags =0 , may_flags =0 , file_info =0 ;int rc =0 ;int contxt_cnt =0 , query_disk_id =0 ; -int maximal_access_ctxt =0 , posix_ctxt =0 ; +bool maximal_access_ctxt = false, posix_ctxt = false;int s_type =0 ;int next_off =0 ;char *name =NULL ;
@@ -2706,6 +2706,27 @@ int smb2_open(struct ksmbd_work *work)return create_smb2_pipe (work); } +if (req->CreateContextsOffset && tcon->posix_extensions) { + context =smb2_find_context_vals (req,SMB2_CREATE_TAG_POSIX ,16 ); +if (IS_ERR (context)) { + rc =PTR_ERR (context); + goto err_out2; + }else if (context) { +struct create_posix *posix = (struct create_posix *)context; + +if (le16_to_cpu (context->DataOffset) + +le32_to_cpu (context->DataLength) < +sizeof (struct create_posix ) -4 ) { + rc = -EINVAL ; + goto err_out2; + } +ksmbd_debug (SMB ,"get posix context\n" ); + + posix_mode =le32_to_cpu (posix->Mode); + posix_ctxt = true; + } + } +if (req->NameLength) {if ((req->CreateOptions &FILE_DIRECTORY_FILE_LE ) && *(char *)req->Buffer =='\\' ) {
@@ -2737,9 +2758,11 @@ int smb2_open(struct ksmbd_work *work) goto err_out2; } - rc =ksmbd_validate_filename (name); -if (rc <0 ) - goto err_out2; +if (posix_ctxt == false) { + rc =ksmbd_validate_filename (name); +if (rc <0 ) + goto err_out2; + }if (ksmbd_share_veto_filename (share, name)) { rc = -ENOENT ;
@@ -2854,28 +2877,6 @@ int smb2_open(struct ksmbd_work *work) rc = -EBADF ; goto err_out2; } - -if (tcon->posix_extensions) { - context =smb2_find_context_vals (req, -SMB2_CREATE_TAG_POSIX ,16 ); -if (IS_ERR (context)) { - rc =PTR_ERR (context); - goto err_out2; - }else if (context) { -struct create_posix *posix = - (struct create_posix *)context; -if (le16_to_cpu (context->DataOffset) + -le32_to_cpu (context->DataLength) < -sizeof (struct create_posix ) -4 ) { - rc = -EINVAL ; - goto err_out2; - } -ksmbd_debug (SMB ,"get posix context\n" ); - - posix_mode =le32_to_cpu (posix->Mode); - posix_ctxt =1 ; - } - } }if (ksmbd_override_fsids (work)) {
Signature · 1 line
2.39.5
Sasha Levin
maintainerPATCH 2/3 Revert "iommu/amd: Prevent binding other PCI drivers to IOMMU PCI devices"
From: Lukas Wunner <[email protected]>
[ Upstream commit 3be5fa236649da6404f1bca1491bf02d4b0d5cce ]
Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") changed IRQ handling on PCI driver probing. It inadvertently broke resume from system sleep on AMD platforms:
https://lore.kernel.org/r/[email protected]/
This was fixed by two independent commits:
* 8affb487d4a4 ("x86/PCI: Don't alloc pcibios-irq when MSI is enabled")
* cbbc00be2ce3 ("iommu/amd: Prevent binding other PCI drivers to IOMMU PCI devices")
The breaking change and one of these two fixes were subsequently reverted:
* fe25d078874f ("Revert "x86/PCI: Don't alloc pcibios-irq when MSI is enabled"")
* 6c777e8799a9 ("Revert "PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()"")
This rendered the second fix unnecessary, so revert it as well. It used the match_driver flag in struct pci_dev, which is internal to the PCI core and not supposed to be touched by arbitrary drivers.
---
**YES**
This commit should be backported to stable kernel trees.
**Extensive Analysis:**
**1. Context and Purpose:**
This commit is part of a coordinated series of reverts addressing regressions introduced by commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") which broke system suspend/resume on AMD platforms in v4.3. The original issue was fixed by two independent commits, one of which (cbbc00be2ce3) added the line iommu->dev->match_driver = false; to prevent other PCI drivers from binding to IOMMU devices.
**2. Code Change Analysis:**
The commit removes exactly one line fromdrivers/iommu/amd/init.c:2034:
```c /* Prevent binding other PCI device drivers to IOMMU devices */ iommu->dev->match_driver = false; ```
This line was setting the match_driver field of struct pci_dev, which the commit message correctly identifies as "internal to the PCI core and not supposed to be touched by arbitrary drivers."
**3. Why This Should Be Backported:**
**a) Part of Coordinated Fix Series:** This revert is the logical completion of a series of reverts that fixed major regressions. Looking at the similar commits provided as examples:
- Similar Commit #1 (YES): Revert of x86/PCI pcibios-irq allocation
- Similar Commit #2 (YES): Revert of PCI IRQ management helpers
- Similar Commit #5 (YES): Revert of the original problematic pcibios_alloc_irq implementation
All these related reverts were marked for backporting, making this commit part of the same logical fix series.
**b) Removes Inappropriate Code:** The commit eliminates code that violates kernel design principles by accessing internal PCI core structures from a driver. The match_driver field is not meant to be manipulated by individual drivers.
**c) Cleanup After Main Fix:** Once the root cause (commit 991de2e59090) was reverted by commit 6c777e8799a9, the workaround became unnecessary. Keeping unnecessary workaround code, especially code that inappropriately accesses internal structures, is problematic.
**d) Minimal Risk:** The change is extremely small and low-risk - it simply removes one line that was setting an internal field inappropriately.
**e) Consistency and Completeness:** Since the other reverts in this series addressing the 991de2e59090 regressions were backported, this should be included for consistency and to ensure the cleanup is complete.
**4. Stable Tree Criteria Met:**
- ✅ Fixes inappropriate driver behavior (accessing internal PCI structures)
- ✅ Small and contained change
- ✅ Part of a series addressing known regressions
- ✅ Minimal risk of introducing new issues
- ✅ Consistent with backporting decisions for related commits
The commit represents necessary cleanup after a coordinated regression fix and should be backported to maintain consistency with the related reverts and to remove code that inappropriately accesses internal kernel structures.
drivers/iommu/amd/init.c | 3 --- 1 file changed, 3 deletions(-)
drivers/iommu/amd/init.c +0 -3
@@ -1870,9 +1870,6 @@ static int __init iommu_init_pci(struct amd_iommu *iommu)if (!iommu->dev)return -ENODEV ; -/* Prevent binding other PCI device drivers to IOMMU devices */ - iommu->dev->match_driver = false; -/* ACPI _PRT won't have an IRQ for IOMMU */ iommu->dev->irq_managed =1 ;
Signature · 1 line
2.39.5
Sasha Levin
maintainerPATCH 3/3 dmaengine: xilinx_dma: Set dma_device directions
In reply to Sasha LevinFrom: Thomas Gessler <[email protected]>
[ Upstream commit 7e01511443c30a55a5ae78d3debd46d4d872517e ]
Coalesce the direction bits from the enabled TX and/or RX channels into the directions bit mask of dma_device. Without this mask set, dma_get_slave_caps() in the DMAEngine fails, which prevents the driver from being used with an IIO DMAEngine buffer.
---
**YES**
## Analysis
This commit should be backported to stable kernel trees because it fixes a critical functionality bug that prevents the Xilinx DMA driver from working with important subsystems.
### The Problem
The commit addresses a fundamental issue where dma_get_slave_caps() fails when called on Xilinx DMA channels. The code change shows that the driver was not setting the directions field in the dma_device structure:
```c + xdev->common.directions |= chan->direction; ```
This single line fix accumulates the direction capabilities from individual channels (either DMA_MEM_TO_DEV or DMA_DEV_TO_MEM) into the device-level directions bitmask.
### Why This Qualifies for Backporting
1. **Fixes Important User-Facing Bug**: The commit message explicitly states this prevents the driver from being used with IIO DMAEngine buffers, which is a significant functional regression affecting real users.
2. **Small and Contained Fix**: The change is minimal - just one line of code that sets a required field during channel probe. This has extremely low risk of introducing regressions.
3. **Critical Subsystem Integration**: Without this fix, dma_get_slave_caps() calls fail with -ENXIO, breaking integration with any subsystem that queries DMA capabilities (like IIO).
4. **Clear Root Cause**: The fix directly addresses the root cause - the missing directions field that the DMAEngine core requires to be set.
5. **No Architectural Changes**: This doesn't introduce new features or change driver architecture; it simply provides required capability information that was missing.
### Comparison to Reference Commits
This closely matches **Similar Commit #1** (marked YES) which also fixed a missing capability flag (DMA_CYCLIC cap_mask bit) that prevented proper DMA channel allocation. Both commits:
- Fix missing capability declarations
- Are small, single-line changes
- Address integration failures with other subsystems
- Have minimal regression risk
The commit also mirrors **Similar Commit #2** (marked YES) which fixed incorrect struct usage in the same driver - both address functional correctness issues in the Xilinx DMA driver.
### Risk Assessment
The risk is minimal because:
- The change only affects the capability reporting mechanism
- It doesn't modify any data paths or transfer logic
- The direction values being OR'd together are already correctly set per-channel
- Failure mode is obvious (capability queries will work instead of failing)
This is a textbook example of a stable tree candidate: it fixes an important bug affecting real users with a minimal, low-risk change that doesn't introduce new functionality.
drivers/dma/xilinx/xilinx_dma.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/dma/xilinx/xilinx_dma.c +2 -0
@@ -2861,6 +2861,8 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,return -EINVAL ; } + xdev->common.directions |= chan->direction; +/* Request the interrupt */ chan->irq =irq_of_parse_and_map (node, chan->tdest); err = request_irq(chan->irq, xdev->dma_config->irq_handler,
Signature · 1 line
2.39.5