arm64: dts: rockchip: Remove workaround that prevented Turing RK1 GPU power regulator control
Subsystems (3)
PATCH RESEND 1/1 arm64: dts: rockchip: Remove workaround that prevented Turing RK1 GPU power regulator control
The RK3588 GPU power domain cannot be activated unless the external power regulator is already on. When GPU support was added to this DT, we had no way to represent this requirement, so regulator-always-on was added to the vdd_gpu_s0 regulator in order to ensure stability. A later patch series (see "Fixes:" commit) resolved this shortcoming, but that commit left the workaround -- and rendered the comment above it no longer correct.
Remove the workaround to allow the GPU power regulator to power off, now that the DT includes the necessary information to power it back on correctly.
---
Hi friends,
This is a patch from about two weeks ago that I failed to address to all relevant recipients, so I'm resending it with the recipients of the "Fixes:" commit included, as I should have done originally.
The original thread had no discussion.
Well wishes,
Sam
--- arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi | 11 ----------- 1 file changed, 11 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi +0 -11
@@ -398,17 +398,6 @@ rk806_dvs3_null: dvs3-null-pins { regulators { vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 { - /* - * RK3588's GPU power domain cannot be enabled - * without this regulator active, but it - * doesn't have to be on when the GPU PD is - * disabled. Because the PD binding does not - * currently allow us to express this - * relationship, we have no choice but to do - * this instead: - */ - regulator-always-on; - regulator-boot-on; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>;
Signature · 1 line
2.48.1
Quoted 9 lines · Sam Edwards
The RK3588 GPU power domain cannot be activated unless the external power regulator is already on. When GPU support was added to this DT, we had no way to represent this requirement, so
regulator-always-onwas added to thevdd_gpu_s0regulator in order to ensure stability. A later patch series (see "Fixes:" commit) resolved this shortcoming, but that commit left the workaround -- and rendered the comment above it no longer correct.[...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Remove workaround that prevented Turing RK1 GPU power regulator control
commit: 5952996d5303c96702ef30ad30ec0a01acda46d4
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>