Skip to contentSkip to conversation

net: bcmgenet: add support for GRO software interrupt coalescing

PATCH In review Zak Kemble 2 participants 4 messages Jun 9, 2025

Subsystems (3)
lore
Share & tools
lore

Zak Kemble

author
#0 lore raw

cover net: bcmgenet: add support for GRO software interrupt coalescing

Reposting as requested here https://lore.kernel.org/all/[email protected]

Hey, these patches enable support for software IRQ coalescing and GRO aggregation and applies conservative defaults which can help improve system and network performance by reducing the number of hardware interrupts and improving GRO aggregation ratio.

Zak Kemble (2):
net: bcmgenet: use napi_complete_done return value
net: bcmgenet: enable GRO software interrupt coalescing by default

 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.39.5
author
#1 lore raw

PATCH 1/2 net: bcmgenet: use napi_complete_done return value

Make use of the return value from napi_complete_done(). This allows users to use the gro_flush_timeout and napi_defer_hard_irqs sysfs attributes for configuring software interrupt coalescing.

---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/broadcom/genet/bcmgenet.c +1 -3
index fa0077bc6..cc9bdd244 100644
@@ -2472,10 +2472,8 @@ static int bcmgenet_rx_poll(struct napi_struct *napi, int budget)
 
 	work_done = bcmgenet_desc_rx(ring, budget);
 
-	if (work_done < budget) {
-		napi_complete_done(napi, work_done);
+	if (work_done < budget && napi_complete_done(napi, work_done))
 		bcmgenet_rx_ring_int_enable(ring);
-	}
 
 	if (ring->dim.use_dim) {
 		dim_update_sample(ring->dim.event_ctr, ring->dim.packets,
Signature · 1 line
2.39.5
author
#2 lore raw

PATCH 2/2 net: bcmgenet: enable GRO software interrupt coalescing by default

In reply to Zak Kemble

Apply conservative defaults.

---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/broadcom/genet/bcmgenet.c +2 -0
index cc9bdd244..4f40f6afe 100644
@@ -3986,6 +3986,8 @@ static int bcmgenet_probe(struct platform_device *pdev)
 	dev->hw_features |= dev->features;
 	dev->vlan_features |= dev->features;
 
+	netdev_sw_irq_coalesce_default_on(dev);
+
 	/* Request the WOL interrupt and advertise suspend if available */
 	priv->wol_irq_disabled = true;
 	if (priv->wol_irq > 0) {
Signature · 1 line
2.39.5
maintainer
#3 lore raw
In reply to Zak Kemble

Hi Zak,

Quoted 6 lines · Zak Kemble

Reposting as requested here https://lore.kernel.org/all/[email protected]

Hey, these patches enable support for software IRQ coalescing and GRO aggregation and applies conservative defaults which can help improve system and network performance by reducing the number of hardware interrupts and improving GRO aggregation ratio.

Since I gave you Tested-by and Reviewed-by tags, you should have been amending your commits with such tags, also you should be specifying the tree you are targeting, in that case it is "net-next", so the patches should be:

[PATCH net-next 0/2]
[PATCH net-next 1/2] ...
[PATCH net-next 2/2] ...

etc.

Please wait 24hrs before reposting an updated version with the tags and proper prefixing, thanks!

Signature · 1 line
Florian