Skip to contentSkip to conversation

selftests/net: packetdrill: more xfail changes

PATCH Applied Jakub Kicinski 4 participants 4 messages Jun 10, 2025 – Jun 11, 2025

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 selftests/net: packetdrill: more xfail changes

Most of the packetdrill tests have not flaked once last week. Add the few which did to the XFAIL list.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Every time I sit down to add more I plan to just XFAIL all of packetdrill on slow machines, but then I convince myself otherwise. One last time?

---
 tools/testing/selftests/net/packetdrill/ksft_runner.sh | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/selftests/net/packetdrill/ksft_runner.sh +4 -0
index ef8b25a606d8..c5b01e1bd4c7 100755
@@ -39,11 +39,15 @@ if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then
 	# xfail tests that are known flaky with dbg config, not fixable.
 	# still run them for coverage (and expect 100% pass without dbg).
 	declare -ar xfail_list=(
+		"tcp_blocking_blocking-connect.pkt"
+		"tcp_blocking_blocking-read.pkt"
 		"tcp_eor_no-coalesce-retrans.pkt"
 		"tcp_fast_recovery_prr-ss.*.pkt"
+		"tcp_sack_sack-route-refresh-ip-tos.pkt"
 		"tcp_slow_start_slow-start-after-win-update.pkt"
 		"tcp_timestamping.*.pkt"
 		"tcp_user_timeout_user-timeout-probe.pkt"
+		"tcp_zerocopy_cl.*.pkt"
 		"tcp_zerocopy_epoll_.*.pkt"
 		"tcp_tcp_info_tcp-info-.*-limited.pkt"
 	)
Signature · 1 line
2.49.0
Acked-by on v1 1/1
#1 lore raw

Hi Jakub,

Quoted 2 lines · Jakub Kicinski

Most of the packetdrill tests have not flaked once last week. Add the few which did to the XFAIL list.

Thank you for monitoring these tests!

Quoted 9 lines

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Every time I sit down to add more I plan to just XFAIL all of packetdrill on slow machines, but then I convince myself otherwise. One last time?

:)

Did some of these packetdrill tests fail only when using a debug kernel? But yes, I guess we can always say: "maybe one day that will pay off" :)

As long as it is manageable!

Quoted 9 lines
---
 tools/testing/selftests/net/packetdrill/ksft_runner.sh | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/selftests/net/packetdrill/ksft_runner.sh +0 -0
index ef8b25a606d8..c5b01e1bd4c7 100755

tools/testing/selftests/net/packetdrill/ksft_runner.sh if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then · line 43

Quoted 5 lines
tools/testing/selftests/net/packetdrill/ksft_runner.sh +2 -0
@@ -39,11 +39,15 @@ if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then
 	# xfail tests that are known flaky with dbg config, not fixable.
 	# still run them for coverage (and expect 100% pass without dbg).
 	declare -ar xfail_list=(
+		"tcp_blocking_blocking-connect.pkt"
+		"tcp_blocking_blocking-read.pkt"

Please note that these two tests have "--tolerance_usecs=10000" in their script. This is overridden by the command line option added above when KSFT_MACHINE_SLOW is defined: "--tolerance_usecs=14000". But maybe for these two tests, the tolerance should be even higher than 14000 when using a debug kernel?

But maybe still better to add them to the XFAIL list and keep the code as it is.

tools/testing/selftests/net/packetdrill/ksft_runner.sh if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then · line 53

Quoted 10 lines
tools/testing/selftests/net/packetdrill/ksft_runner.sh +2 -0
 		"tcp_eor_no-coalesce-retrans.pkt"
 		"tcp_fast_recovery_prr-ss.*.pkt"
+		"tcp_sack_sack-route-refresh-ip-tos.pkt"
 		"tcp_slow_start_slow-start-after-win-update.pkt"
 		"tcp_timestamping.*.pkt"
 		"tcp_user_timeout_user-timeout-probe.pkt"
+		"tcp_zerocopy_cl.*.pkt"
 		"tcp_zerocopy_epoll_.*.pkt"
 		"tcp_tcp_info_tcp-info-.*-limited.pkt"
 	)

Cheers,
Matt

Signature · 1 line
Sponsored by the NGI0 Core fund.
#3 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Mon, 9 Jun 2025 17:00:01 -0700 you wrote:

Most of the packetdrill tests have not flaked once last week. Add the few which did to the XFAIL list.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

[...]

Here is the summary with links:
- [net-next] selftests/net: packetdrill: more xfail changes

    https://git.kernel.org/netdev/net-next/c/265c6ff0f8c2

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html