f2fs: do sanity check on fio.new_blkaddr in do_write_page()
Chao Yu
maintainerPATCH 1/1 f2fs: do sanity check on fio.new_blkaddr in do_write_page()
F2FS-fs (dm-55): access invalid blkaddr:972878540
Call trace: dump_backtrace+0xec/0x128 show_stack+0x18/0x28 dump_stack_lvl+0x40/0x88 dump_stack+0x18/0x24 __f2fs_is_valid_blkaddr+0x360/0x3b4 f2fs_is_valid_blkaddr+0x10/0x20 f2fs_get_node_info+0x21c/0x60c __write_node_page+0x15c/0x734 f2fs_sync_node_pages+0x4f8/0x700 f2fs_write_checkpoint+0x4a8/0x99c __checkpoint_and_complete_reqs+0x7c/0x20c issue_checkpoint_thread+0x4c/0xd8 kthread+0x11c/0x1b0 ret_from_fork+0x10/0x20
If f2fs_allocate_data_block() fails, we may update nat.blkaddr w/ uninitialized fio.new_blkaddr.
- __write_node_folio
- f2fs_do_write_node_page
- do_write_page
- f2fs_allocate_data_block
: once it fails, it may not allocate new blkaddr
- set_node_addr
: update w/ uninitialized fio.new_blkaddr variable
I've checked all error paths in f2fs_allocate_data_block(), it should be tagged w/ CP_ERROR_FLAG.
In addition, f2fs_allocate_data_block() succeeds, fio.new_blkaddr should be valid.
Let's add f2fs_bug_on() to check above two conditions to detect any potential bugs.
--- fs/f2fs/segment.c | 6 ++++++ 1 file changed, 6 insertions(+)
fs/f2fs/segment.c +6 -0
@@ -3948,8 +3948,14 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)folio_end_writeback (folio);if (f2fs_in_warm_node_list (fio->sbi, folio))f2fs_del_fsync_node_entry (fio->sbi, folio); +f2fs_bug_on (fio->sbi, !is_set_ckpt_flags (fio->sbi, +CP_ERROR_FLAG )); goto out; } + +f2fs_bug_on (fio->sbi, !f2fs_is_valid_blkaddr (fio->sbi, + fio->new_blkaddr,DATA_GENERIC_ENHANCE )); +if (GET_SEGNO (fio->sbi, fio->old_blkaddr) !=NULL_SEGNO )f2fs_invalidate_internal_cache (fio->sbi, fio->old_blkaddr,1 );
Signature · 1 line
2.49.0
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 17 lines · On Tue, 10 Jun 2025 11:13:15 +0800 you wrote:
F2FS-fs (dm-55): access invalid blkaddr:972878540
Call trace: dump_backtrace+0xec/0x128 show_stack+0x18/0x28 dump_stack_lvl+0x40/0x88 dump_stack+0x18/0x24 __f2fs_is_valid_blkaddr+0x360/0x3b4 f2fs_is_valid_blkaddr+0x10/0x20 f2fs_get_node_info+0x21c/0x60c __write_node_page+0x15c/0x734 f2fs_sync_node_pages+0x4f8/0x700 f2fs_write_checkpoint+0x4a8/0x99c __checkpoint_and_complete_reqs+0x7c/0x20c issue_checkpoint_thread+0x4c/0xd8 kthread+0x11c/0x1b0 ret_from_fork+0x10/0x20
Quoted 1 line
[...]
Here is the summary with links:
- [f2fs-dev] f2fs: do sanity check on fio.new_blkaddr in do_write_page()
https://git.kernel.org/jaegeuk/f2fs/c/70b6e8500431
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html