Skip to contentSkip to conversation

Add `devm_dma_request_chan()` to simplify probe path in atmel-quadspi.c

PATCH Applied Bence Csókás 4 participants 9 messages Jun 10, 2025 – Aug 26, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v7 cover Add `devm_dma_request_chan()` to simplify probe path in atmel-quadspi.c

The probe function of the atmel-quadspi driver got quite convoluted, especially since the addition of SAMA7G5 support, that was forward-ported from an older vendor kernel. To alleivate this - and similar problems in the future - an effort was made to migrate as many functions as possible, to their devm_ managed counterparts. Patch 1/2 adds the new devm_dma_request_chan() function. Patch 2/2 then uses this APIs to simplify the probe() function.

Change in v4:
* split PM imbalance fix (now merged) and DMA cleanup (this series) Change in v6:
* rebase to spi/for-next
Change in v7:
* rebase to dma/next

[1]
commit 3c018bf5a0ee ("dmaengine: idxd: Remove unused pointer and macro")

Links to previous versions:
pre-series:
https://lore.kernel.org/linux-kernel/[email protected]/
https://lore.kernel.org/linux-kernel/[email protected]/
v1:
https://lore.kernel.org/linux-kernel/[email protected]/
v2:
https://lore.kernel.org/linux-kernel/[email protected]/
v3:
https://lore.kernel.org/linux-kernel/[email protected]/
v4:
https://lore.kernel.org/lkml/[email protected]/
v5:
https://lore.kernel.org/lkml/[email protected]
v6:
https://lore.kernel.org/lkml/[email protected]

Bence Csókás (2):
dma: Add devm_dma_request_chan()
spi: atmel-quadspi: Use devm_dma_request_chan()

 drivers/dma/dmaengine.c     | 30 +++++++++++++++++++++++
 drivers/spi/atmel-quadspi.c | 48 ++++++++++---------------------------
 include/linux/dmaengine.h   |  7 ++++++
 3 files changed, 50 insertions(+), 35 deletions(-)

base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494

Signature · 1 line
2.43.0
#1 lore raw

PATCH v7 1/2 dma: Add devm_dma_request_chan()

Expand the arsenal of devm functions for DMA devices, this time for requesting channels.

---
 drivers/dma/dmaengine.c   | 30 ++++++++++++++++++++++++++++++
 include/linux/dmaengine.h |  7 +++++++
 2 files changed, 37 insertions(+)
drivers/dma/dmaengine.c +30 -0
index 758fcd0546d8..ca13cd39330b 100644
@@ -926,6 +926,36 @@ void dma_release_channel(struct dma_chan *chan)
 }
 EXPORT_SYMBOL_GPL(dma_release_channel);
 
+static void dmaenginem_release_channel(void *chan)
+{
+	dma_release_channel(chan);
+}
+
+/**
+ * devm_dma_request_chan - try to allocate an exclusive slave channel
+ * @dev:	pointer to client device structure
+ * @name:	slave channel name
+ *
+ * Returns pointer to appropriate DMA channel on success or an error pointer.
+ *
+ * The operation is managed and will be undone on driver detach.
+ */
+
+struct dma_chan *devm_dma_request_chan(struct device *dev, const char *name)
+{
+	struct dma_chan *chan = dma_request_chan(dev, name);
+	int ret = 0;
+
+	if (!IS_ERR(chan))
+		ret = devm_add_action_or_reset(dev, dmaenginem_release_channel, chan);
+
+	if (ret)
+		return ERR_PTR(ret);
+
+	return chan;
+}
+EXPORT_SYMBOL_GPL(devm_dma_request_chan);
+
 /**
  * dmaengine_get - register interest in dma_channels
  */
include/linux/dmaengine.h +7 -0
index bb146c5ac3e4..6de7c05d6bd8 100644
@@ -1524,6 +1524,7 @@ struct dma_chan *__dma_request_channel(const dma_cap_mask_t *mask,
 
 struct dma_chan *dma_request_chan(struct device *dev, const char *name);
 struct dma_chan *dma_request_chan_by_mask(const dma_cap_mask_t *mask);
+struct dma_chan *devm_dma_request_chan(struct device *dev, const char *name);
 
 void dma_release_channel(struct dma_chan *chan);
 int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps);
@@ -1560,6 +1561,12 @@ static inline struct dma_chan *dma_request_chan_by_mask(
 {
 	return ERR_PTR(-ENODEV);
 }
+
+static inline struct dma_chan *devm_dma_request_chan(struct device *dev, const char *name)
+{
+	return ERR_PTR(-ENODEV);
+}
+
 static inline void dma_release_channel(struct dma_chan *chan)
 {
 }
Signature · 1 line
2.43.0
#2 lore raw

Re: [PATCH v7 1/2] dma: Add devm_dma_request_chan()

Tue, Jun 10, 2025 at 10:22:53AM +0200, Bence Csókás kirjoitti:

Quoted 2 lines

Expand the arsenal of devm functions for DMA devices, this time for requesting channels.

...

Quoted 8 lines

+/**
+ * devm_dma_request_chan - try to allocate an exclusive slave channel
+ * @dev: pointer to client device structure
+ * @name: slave channel name
+ *
+ * Returns pointer to appropriate DMA channel on success or an error pointer.
+ *
+ * The operation is managed and will be undone on driver detach.

This introduced a kernel-doc validation issue (Missing Return section).

Quoted 3 lines

+ */

+

Unneeded blank line.

drivers/dma/dmaengine.c void dma_release_channel(struct dma_chan *chan) · line 955

Quoted 12 lines
drivers/dma/dmaengine.c +11 -0
+struct dma_chan *devm_dma_request_chan(struct device *dev, const char *name)
 
+	struct dma_chan *chan = dma_request_chan(dev, name);
+	int ret = 0;
+
+	if (!IS_ERR(chan))
+		ret = devm_add_action_or_reset(dev, dmaenginem_release_channel, chan);
+
+	if (ret)
+		return ERR_PTR(ret);
+
+	return chan;

Hmm... We usually use "error check" pattern
Compare to

	struct dma_chan *chan;
	int ret;

	chan = dma_request_chan(dev, name);
	if (IS_ERR(chan))
		return chan;

	ret = devm_add_action_or_reset(dev, dmaenginem_release_channel, chan);
	if (ret)
		return ERR_PTR(ret);

	return chan;
Quoted 1 line

+}

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

PATCH v7 2/2 spi: atmel-quadspi: Use `devm_dma_request_chan()`

In reply to Bence Csókás

Leave releasing of DMA channels up to the devm facilities. This way we can eliminate the rest of the "goto ladder".

---
 drivers/spi/atmel-quadspi.c | 48 ++++++++++---------------------------
 1 file changed, 13 insertions(+), 35 deletions(-)
drivers/spi/atmel-quadspi.c +13 -35
index 2f6797324227..fc555c0ce52e 100644
@@ -1285,18 +1285,21 @@ static int atmel_qspi_dma_init(struct spi_controller *ctrl)
 	struct atmel_qspi *aq = spi_controller_get_devdata(ctrl);
 	int ret;
 
-	aq->rx_chan = dma_request_chan(&aq->pdev->dev, "rx");
+	aq->rx_chan = devm_dma_request_chan(&aq->pdev->dev, "rx");
 	if (IS_ERR(aq->rx_chan)) {
 		ret = dev_err_probe(&aq->pdev->dev, PTR_ERR(aq->rx_chan),
 				    "RX DMA channel is not available\n");
-		goto null_rx_chan;
+		aq->rx_chan = NULL;
+		return ret;
 	}
 
-	aq->tx_chan = dma_request_chan(&aq->pdev->dev, "tx");
+	aq->tx_chan = devm_dma_request_chan(&aq->pdev->dev, "tx");
 	if (IS_ERR(aq->tx_chan)) {
 		ret = dev_err_probe(&aq->pdev->dev, PTR_ERR(aq->tx_chan),
 				    "TX DMA channel is not available\n");
-		goto release_rx_chan;
+		aq->rx_chan = NULL;
+		aq->tx_chan = NULL;
+		return ret;
 	}
 
 	ctrl->dma_rx = aq->rx_chan;
@@ -1307,21 +1310,6 @@ static int atmel_qspi_dma_init(struct spi_controller *ctrl)
 		 dma_chan_name(aq->tx_chan), dma_chan_name(aq->rx_chan));
 
 	return 0;
-
-release_rx_chan:
-	dma_release_channel(aq->rx_chan);
-	aq->tx_chan = NULL;
-null_rx_chan:
-	aq->rx_chan = NULL;
-	return ret;
-}
-
-static void atmel_qspi_dma_release(struct atmel_qspi *aq)
-{
-	if (aq->rx_chan)
-		dma_release_channel(aq->rx_chan);
-	if (aq->tx_chan)
-		dma_release_channel(aq->tx_chan);
 }
 
 static const struct atmel_qspi_ops atmel_qspi_ops = {
@@ -1426,14 +1414,13 @@ static int atmel_qspi_probe(struct platform_device *pdev)
 
 	/* Request the IRQ */
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		err = irq;
-		goto dma_release;
-	}
+	if (irq < 0)
+		return irq;
+
 	err = devm_request_irq(&pdev->dev, irq, atmel_qspi_interrupt,
 			       0, dev_name(&pdev->dev), aq);
 	if (err)
-		goto dma_release;
+		return err;
 
 	pm_runtime_set_autosuspend_delay(&pdev->dev, 500);
 	pm_runtime_use_autosuspend(&pdev->dev);
@@ -1442,22 +1429,16 @@ static int atmel_qspi_probe(struct platform_device *pdev)
 
 	err = atmel_qspi_init(aq);
 	if (err)
-		goto dma_release;
+		return err;
 
 	err = spi_register_controller(ctrl);
 	if (err)
-		goto dma_release;
+		return err;
 
 	pm_runtime_mark_last_busy(&pdev->dev);
 	pm_runtime_put_autosuspend(&pdev->dev);
 
 	return 0;
-
-dma_release:
-	if (aq->caps->has_dma)
-		atmel_qspi_dma_release(aq);
-
-	return err;
 }
 
 static int atmel_qspi_sama7g5_suspend(struct atmel_qspi *aq)
@@ -1507,9 +1488,6 @@ static void atmel_qspi_remove(struct platform_device *pdev)
 
 	ret = pm_runtime_get_sync(&pdev->dev);
 	if (ret >= 0) {
-		if (aq->caps->has_dma)
-			atmel_qspi_dma_release(aq);
-
 		if (aq->caps->has_gclk) {
 			ret = atmel_qspi_sama7g5_suspend(aq);
 			if (ret)
Signature · 1 line
2.43.0
maintainer
#4 lore raw
In reply to Bence Csókás
Quoted 3 lines · Bence Csókás

to their devm_ managed counterparts. Patch 1/2 adds the new devm_dma_request_chan() function. Patch 2/2 then uses this APIs to simplify the probe() function.

I'm not copied on patch 1, please let me know if/when there's some progress there.

maintainer
#5 lore raw
Quoted 8 lines · Mark Brown
Quoted 3 lines · Bence Csókás

to their devm_ managed counterparts. Patch 1/2 adds the new devm_dma_request_chan() function. Patch 2/2 then uses this APIs to simplify the probe() function.

I'm not copied on patch 1, please let me know if/when there's some progress there.

You can pull in this tag for the dependency

The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:

Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git tags/dmaengine_devm_api

for you to fetch changes up to 08bf1663c21a3e815eda28fa242d84c945ca3b94:

dmaengine: Add devm_dma_request_chan() (2025-06-26 15:18:04 -0700)

----------------------------------------------------------------
dmaengine: tag for devm api

----------------------------------------------------------------
Bence Csókás (1):
dmaengine: Add devm_dma_request_chan()

 drivers/dma/dmaengine.c   | 30 ++++++++++++++++++++++++++++++
 include/linux/dmaengine.h |  7 +++++++
 2 files changed, 37 insertions(+)

Thanks

Signature · 1 line
~Vinod
maintainer Applied
#6 lore raw

Re: (subset) [PATCH v7 0/2] Add `devm_dma_request_chan()` to simplify probe path in atmel-quadspi.c

In reply to Bence Csókás
Quoted 9 lines · Bence Csókás

The probe function of the atmel-quadspi driver got quite convoluted, especially since the addition of SAMA7G5 support, that was forward-ported from an older vendor kernel. To alleivate this - and similar problems in the future - an effort was made to migrate as many functions as possible, to their devm_ managed counterparts. Patch 1/2 adds the new devm_dma_request_chan() function. Patch 2/2 then uses this APIs to simplify the probe() function.

[...]

Applied, thanks!

[1/2] dma: Add devm_dma_request_chan()

      commit: 56137a53f8ebb400f4098ca26ef18934e9a4de45

Best regards,

Signature · 1 line
~Vinod
maintainer Applied
#7 lore raw
In reply to Bence Csókás
Quoted 9 lines · Bence Csókás

The probe function of the atmel-quadspi driver got quite convoluted, especially since the addition of SAMA7G5 support, that was forward-ported from an older vendor kernel. To alleivate this - and similar problems in the future - an effort was made to migrate as many functions as possible, to their devm_ managed counterparts. Patch 1/2 adds the new devm_dma_request_chan() function. Patch 2/2 then uses this APIs to simplify the probe() function.

[...]

Applied, thanks!

[1/2] dma: Add devm_dma_request_chan()

      commit: 08bf1663c21a3e815eda28fa242d84c945ca3b94

[2/2] spi: atmel-quadspi: Use devm_dma_request_chan()
(no commit info)

Best regards,

Signature · 1 line
~Vinod
maintainer
#8 lore raw
In reply to Bence Csókás
Quoted 9 lines · Bence Csókás

The probe function of the atmel-quadspi driver got quite convoluted, especially since the addition of SAMA7G5 support, that was forward-ported from an older vendor kernel. To alleivate this - and similar problems in the future - an effort was made to migrate as many functions as possible, to their devm_ managed counterparts. Patch 1/2 adds the new devm_dma_request_chan() function. Patch 2/2 then uses this APIs to simplify the probe() function.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] dma: Add devm_dma_request_chan()
(no commit info)
[2/2] spi: atmel-quadspi: Use devm_dma_request_chan()

      commit: 2555691165a0285a4617230fed859f20dcc51608

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark