Skip to contentSkip to conversation

net: pfcp: fix typo in message_priority field name

PATCH Superseded RubenKelevra 4 participants 7 messages Jun 10, 2025 – Jun 14, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: pfcp: fix typo in message_priority field name

Fix 'message_priprity' typo to 'message_priority' in big endian bitfield definition. This typo breaks compilation on big endian architectures.

Fixes 6dd514f48110 ("pfcp: always set pfcp metadata")
Cc [email protected] # commit 6dd514f48110 ("pfcp: always set pfcp metadata")
---
 include/net/pfcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/pfcp.h +1 -1
index af14f970b80e1..639553797d3e4 100644
@@ -45,7 +45,7 @@ struct pfcphdr_session {
 		reserved:4;
 #elif defined(__BIG_ENDIAN_BITFIELD)
 	u8	reserved:4,
-		message_priprity:4;
+		message_priority:4;
 #else
 #error "Please fix <asm/byteorder>"
 #endif
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · RubenKelevra

Fix 'message_priprity' typo to 'message_priority' in big endian bitfield definition. This typo breaks compilation on big endian architectures.

Fixes 6dd514f48110 ("pfcp: always set pfcp metadata")
Cc [email protected] # commit 6dd514f48110 ("pfcp: always set pfcp metadata")
---
 include/net/pfcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I had the same issue today, happy there's a patch for this.

maintainer
#2 lore raw
Quoted 9 lines · On Tue, 10 Jun 2025 18:42:28 +0000 Charalampos Mitrodimas wrote:
Quoted 7 lines

Fix 'message_priprity' typo to 'message_priority' in big endian bitfield definition. This typo breaks compilation on big endian architectures.

Fixes 6dd514f48110 ("pfcp: always set pfcp metadata")
Cc [email protected] # commit 6dd514f48110 ("pfcp: always set pfcp metadata")

I had the same issue today, happy there's a patch for this.

Could y'all share more? What compilation does this break? The field is never used.

More info about how you found the problem would be useful. And I believe this can go to net-next, without the CC stable and without the Fixes tag. Unless my grep is lying to me:

net-next$ git grep message_priority
include/net/pfcp.h: u8 message_priority:4,

Signature · 1 line
pw-bot: cr
#3 lore raw

Hi Jakub,

I hit it while building an out-of-tree module that reads hdr->message_priority. Cross-compiling for a big-endian target failed for me, because of it.

That’s the only reason for the patch; net-next is fine, no need for stable.

Cheers,
Ruben

Quoted 23 lines · Jakub Kicinski
Quoted 9 lines · On Tue, 10 Jun 2025 18:42:28 +0000 Charalampos Mitrodimas wrote:
Quoted 7 lines

Fix 'message_priprity' typo to 'message_priority' in big endian bitfield definition. This typo breaks compilation on big endian architectures.

Fixes 6dd514f48110 ("pfcp: always set pfcp metadata")
Cc [email protected] # commit 6dd514f48110 ("pfcp: always set pfcp metadata")

I had the same issue today, happy there's a patch for this.

Could y'all share more? What compilation does this break? The field is never used.

More info about how you found the problem would be useful. And I believe this can go to net-next, without the CC stable and without the Fixes tag. Unless my grep is lying to me:

net-next$ git grep message_priority
include/net/pfcp.h: u8 message_priority:4,
--
pw-bot: cr

maintainer
#4 lore raw
Quoted 4 lines · On Thu, 12 Jun 2025 08:38:20 +0200 Ruben Kelevra wrote:

I hit it while building an out-of-tree module that reads hdr->message_priority. Cross-compiling for a big-endian target failed for me, because of it.

That’s the only reason for the patch; net-next is fine, no need for stable.

I see, please go ahead and repost with [PATCH net-next], no stable cc and no fixes tag. Would also be good to mention in the commit message that it does not currently cause kernel build issues, but is clearly incorrect.

#5 lore raw

PATCH v2 1/1 net: pfcp: fix typo in message_priority field name

In reply to RubenKelevra

The field is spelled “message_priprity” in the big-endian bit-field definition. Nothing in-tree currently references the member, so the typo does not break kernel builds, but it is clearly incorrect and confuses out-of-tree code.

---
 include/net/pfcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/pfcp.h +1 -1
index af14f970b80e1..639553797d3e4 100644
@@ -45,7 +45,7 @@ struct pfcphdr_session {
 		reserved:4;
 #elif defined(__BIG_ENDIAN_BITFIELD)
 	u8	reserved:4,
-		message_priprity:4;
+		message_priority:4;
 #else
 #error "Please fix <asm/byteorder>"
 #endif
Signature · 1 line
2.49.0
#6 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Thu, 12 Jun 2025 16:50:12 +0200 you wrote:

The field is spelled “message_priprity” in the big-endian bit-field definition. Nothing in-tree currently references the member, so the typo does not break kernel builds, but it is clearly incorrect and confuses out-of-tree code.

[...]

Here is the summary with links:
- [net-next,v2] net: pfcp: fix typo in message_priority field name

    https://git.kernel.org/netdev/net-next/c/b776999bf25d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html