block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion
Subsystems (2)
Damien Le Moal
maintainerPATCH 1/1 block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion
When blk_zone_write_plug_bio_endio() is called for a regular write BIO used to emulate a zone append operation, that is, a BIO flagged with BIO_EMULATES_ZONE_APPEND, the BIO operation code is restored to the original REQ_OP_ZONE_APPEND but the BIO_EMULATES_ZONE_APPEND flag is not cleared. Clear it to fully return the BIO to its orginal definition.
--- block/blk-zoned.c | 1 + 1 file changed, 1 insertion(+)
block/blk-zoned.c +1 -0
@@ -1254,6 +1254,7 @@ void blk_zone_write_plug_bio_endio(struct bio *bio)if (bio_flagged (bio,BIO_EMULATES_ZONE_APPEND )) { bio->bi_opf &= ~REQ_OP_MASK ; bio->bi_opf |=REQ_OP_ZONE_APPEND ; +bio_clear_flag (bio,BIO_EMULATES_ZONE_APPEND ); }/*
Signature · 1 line
2.49.0
Quoted 5 lines · Damien Le Moal
When
blk_zone_write_plug_bio_endio()is called for a regular write BIO used to emulate a zone append operation, that is, a BIO flagged withBIO_EMULATES_ZONE_APPEND, the BIO operation code is restored to the originalREQ_OP_ZONE_APPENDbut theBIO_EMULATES_ZONE_APPENDflag is not cleared. Clear it to fully return the BIO to its orginal definition.
Looks good:
Quoted 18 lines · Damien Le Moal
When
blk_zone_write_plug_bio_endio()is called for a regular write BIO used to emulate a zone append operation, that is, a BIO flagged withBIO_EMULATES_ZONE_APPEND, the BIO operation code is restored to the originalREQ_OP_ZONE_APPENDbut theBIO_EMULATES_ZONE_APPENDflag is not cleared. Clear it to fully return the BIO to its orginal definition.Fixes 9b1ce7f0c6f8 ("block: Implement zone append emulation")Signed-off-by Damien Le Moal <[email protected]>--- block/blk-zoned.c | 1 + 1 file changed, 1 insertion(+)block/blk-zoned.c +0
-0
block/blk-zoned.c void blk_zone_write_plug_bio_endio(struct bio *bio) · line 1260
Quoted 7 lines
block/blk-zoned.c +1
-0@@ -1254,6 +1254,7 @@ void blk_zone_write_plug_bio_endio(struct bio *bio)if (bio_flagged (bio,BIO_EMULATES_ZONE_APPEND )) { bio->bi_opf &= ~REQ_OP_MASK ; bio->bi_opf |=REQ_OP_ZONE_APPEND ; +bio_clear_flag (bio,BIO_EMULATES_ZONE_APPEND ); }/*
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Looks good,
Quoted 8 lines · Damien Le Moal
When
blk_zone_write_plug_bio_endio()is called for a regular write BIO used to emulate a zone append operation, that is, a BIO flagged withBIO_EMULATES_ZONE_APPEND, the BIO operation code is restored to the originalREQ_OP_ZONE_APPENDbut theBIO_EMULATES_ZONE_APPENDflag is not cleared. Clear it to fully return the BIO to its orginal definition.[...]
Applied, thanks!
[1/1] block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion
commit: f705d33c2f0353039d03e5d6f18f70467d86080e
Best regards,
Signature · 1 line
Jens Axboe