tracefs: Add d_delete to remove negative dentries
Steven Rostedt
maintainerPATCH 1/1 tracefs: Add d_delete to remove negative dentries
From: Steven Rostedt <[email protected]>
If a lookup in tracefs is done on a file that does not exist, it leaves a dentry hanging around until memory pressure removes it. But eventfs dentries should hang around as when their ref count goes to zero, it requires more work to recreate it. For the rest of the tracefs dentries, they hang around as their dentry is used as a descriptor for the tracing system. But if a file lookup happens for a file in tracefs that does not exist, it should be deleted.
Add a .d_delete callback that checks if dentry->fsdata is set or not. Only eventfs dentries set fsdata so if it has content it should not be deleted and should hang around in the cache.
--- fs/tracefs/inode.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
fs/tracefs/inode.c +11 -0
@@ -465,9 +465,20 @@ static int tracefs_d_revalidate(struct inode *inode, const struct qstr *name,return !(ei && ei->is_freed); } +static int tracefs_d_delete (const struct dentry *dentry) +{ +/* +* We want to keep eventfs dentries around but not tracefs +* ones. eventfs dentries have content in d_fsdata. +* Use d_fsdata to determine if it's a eventfs dentry or not. +*/ +return dentry->d_fsdata ==NULL ; +} +static const struct dentry_operations tracefs_dentry_operations = { .d_revalidate = tracefs_d_revalidate, .d_release = tracefs_d_release, + .d_delete = tracefs_d_delete, };static int tracefs_fill_super (struct super_block *sb,struct fs_context *fc)
Signature · 1 line
2.47.2
Al Viro
AppliedQuoted 10 lines · Steven Rostedt
From: Steven Rostedt <[email protected]>
If a lookup in tracefs is done on a file that does not exist, it leaves a dentry hanging around until memory pressure removes it. But eventfs dentries should hang around as when their ref count goes to zero, it requires more work to recreate it. For the rest of the tracefs dentries, they hang around as their dentry is used as a descriptor for the tracing system. But if a file lookup happens for a file in tracefs that does not exist, it should be deleted.
Quoted 6 lines
Add a .d_delete callback that checks if
dentry->fsdatais set or not. Only eventfs dentries set fsdata so if it has content it should not be deleted and should hang around in the cache.Reported-by Al Viro <[email protected]>Signed-off-by Steven Rostedt (Google) <[email protected]>
Applied to #work.dcache