generic/633: add _require_chown
PATCH 1/1 generic/633: add _require_chown
For file systems that do not support chown, such as exfat, running this test does not make sense and should be skipped.
--- tests/generic/633 | 1 + 1 file changed, 1 insertion(+)
tests/generic/633 +1 -0
@@ -13,6 +13,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink . ./common/filter _require_test +_require_chown echo "Silence is golden"
Signature · 1 line
2.25.1
Quoted 2 lines · Yuezhang Mo
For file systems that do not support chown, such as exfat, running this test does not make sense and should be skipped.
/me scans the test, only sees stuff about idmap...
If I read this correctly, exfat doesn't assign individual files a user/group id, so idmapping (which is what this test really does) has very little meaning, because every file is "owned" either by the value provided by the uid= mount option, or the uid of the mount(8) process. Therefore g/633 can't test remapping of select uids.
If that's the case then
--D
Quoted 22 lines
Signed-off-by Yuezhang Mo <[email protected]>Reviewed-by Friendy Su <[email protected]>--- tests/generic/633 | 1 + 1 file changed, 1 insertion(+)tests/generic/633 +1
-0@@ -13,6 +13,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink . ./common/filter _require_test +_require_chown echo "Silence is golden"Signature · 1 line
2.25.1
Quoted 6 lines · Darrick J. Wong
Quoted 2 lines · Yuezhang Mo
For file systems that do not support chown, such as exfat, running this test does not make sense and should be skipped.
/me scans the test, only sees stuff about idmap...
Quoted 8 lines
If I read this correctly, exfat doesn't assign individual files a user/group id, so idmapping (which is what this test really does) has very little meaning, because every file is "owned" either by the value provided by the uid= mount option, or the uid of the mount(8) process. Therefore g/633 can't test remapping of select uids.
If that's the case then
Reviewed-by "Darrick J. Wong" <[email protected]>
Actually it's failed on exfat on my side:
FSTYP -- exfat PLATFORM -- Linux/x86_64 dell-per750-41 6.16.0-0.rc1.250613g27605c8c0f69.21.fc43.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Jun 13 16:05:28 UTC 2025 MKFS_OPTIONS -- /dev/sda6
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/sda6 /mnt/scratch
generic/633 2s ... [failed, exit status 1]- output mismatch (see /root/git/xfstests/results//generic/633.out.bad)
--- tests/generic/633.out 2024-06-07 01:20:04.367004296 +0800
+++ /root/git/xfstests/results//generic/633.out.bad 2025-06-19 00:31:17.760030233 +0800
@@ -1,2 +1,4 @@
QA output created by 633
Silence is golden
+vfstest.c: 110: hardlink_crossing_mounts - Operation not permitted - failure: chown_r
+vfstest.c: 2418: run_test - Operation not permitted - failure: cross mount hardlink
...
(Run 'diff -u /root/git/xfstests/tests/generic/633.out /root/git/xfstests/results//generic/633.out.bad' to see the entire diff)
Ran: generic/633
Failures: generic/633
Failed 1 of 1 tests
Quoted 27 lines
--D
Quoted 22 lines
Signed-off-by Yuezhang Mo <[email protected]>Reviewed-by Friendy Su <[email protected]>--- tests/generic/633 | 1 + 1 file changed, 1 insertion(+)tests/generic/633 +1
-0@@ -13,6 +13,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink . ./common/filter _require_test +_require_chown echo "Silence is golden"Signature · 1 line
2.25.1