char: misc: add test cases
kernel test robot
build botBCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Thadeu Lima de Souza Cascardo <[email protected]>
Hi Thadeu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 19272b37aa4f83ca52bdf9c16d5d81bdd1354494]
url: https://github.com/intel-lab-lkp/linux/commits/Thadeu-Lima-de-Souza-Cascardo/char-misc-add-test-cases/20250613-013440 base: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 patch link: https://lore.kernel.org/r/20250612-misc-dynrange-v5-1-6f35048f7273%40igalia.com patch subject: [PATCH v5] char: misc: add test cases
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago
config: powerpc-randconfig-r072-20250613 (https://download.01.org/0day-ci/archive/20250613/[email protected]/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:drivers/misc/misc_minor_kunit.c:192 miscdev_test_can_open() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +192 drivers/misc/misc_minor_kunit.c
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 177
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 178 static void __init miscdev_test_can_open(struct kunit *test, struct miscdevice *misc)
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 179 {
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 180 int ret;
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 181 struct file *filp;
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 182 char *devname;
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 183
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 184 devname = kasprintf(GFP_KERNEL, "/dev/%s", misc->name);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 185 ret = init_mknod(devname, S_IFCHR | 0600,
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 186 new_encode_dev(MKDEV(MISC_MAJOR, misc->minor)));
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 187 if (ret != 0)
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 188 KUNIT_FAIL(test, "failed to create node\n");
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 189
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 190 filp = filp_open(devname, O_RDONLY, 0);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 191 if (IS_ERR_OR_NULL(filp))
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 @192 KUNIT_FAIL(test, "failed to open misc device: %ld\n", PTR_ERR(filp));
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 193 else
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 194 fput(filp);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 195
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 196 init_unlink(devname);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 197 kfree(devname);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 198 }
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 199 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki