virtio-crypto: Remove unused virtcrypto functions
Subsystems (3)
PATCH 1/1 virtio-crypto: Remove unused virtcrypto functions
From: "Dr. David Alan Gilbert" <[email protected]>
virtcrypto_devmgr_get_first() and virtcrypto_dev_in_use() were added in 2016 by
commit dbaf0624ffa5 ("crypto: add virtio-crypto driver")
but have remained unused.
Remove them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
--- drivers/crypto/virtio/virtio_crypto_common.h | 2 -- drivers/crypto/virtio/virtio_crypto_mgr.c | 36 -------------------- 2 files changed, 38 deletions(-)
drivers/crypto/virtio/virtio_crypto_common.h +0 -2
@@ -113,8 +113,6 @@ struct virtio_crypto_request {int virtcrypto_devmgr_add_dev (struct virtio_crypto *vcrypto_dev);struct list_head *virtcrypto_devmgr_get_head (void );void virtcrypto_devmgr_rm_dev (struct virtio_crypto *vcrypto_dev); -struct virtio_crypto *virtcrypto_devmgr_get_first (void ); -int virtcrypto_dev_in_use (struct virtio_crypto *vcrypto_dev);int virtcrypto_dev_get (struct virtio_crypto *vcrypto_dev);void virtcrypto_dev_put (struct virtio_crypto *vcrypto_dev);int virtcrypto_dev_started (struct virtio_crypto *vcrypto_dev);
drivers/crypto/virtio/virtio_crypto_mgr.c +0 -36
@@ -81,42 +81,6 @@ void virtcrypto_devmgr_rm_dev(struct virtio_crypto *vcrypto_dev)mutex_unlock (&table_lock); } -/* -* virtcrypto_devmgr_get_first() -* -* Function returns the first virtio crypto device from the acceleration -* framework. -* -* To be used by virtio crypto device specific drivers. -* -* Return: pointer to vcrypto_dev or NULL if not found. -*/ -struct virtio_crypto *virtcrypto_devmgr_get_first (void ) -{ -struct virtio_crypto *dev =NULL ; - -mutex_lock (&table_lock); -if (!list_empty (&virtio_crypto_table)) - dev =list_first_entry (&virtio_crypto_table, - struct virtio_crypto, - list); -mutex_unlock (&table_lock); -return dev; -} - -/* -* virtcrypto_dev_in_use() - Check whether vcrypto_dev is currently in use -* @vcrypto_dev: Pointer to virtio crypto device. -* -* To be used by virtio crypto device specific drivers. -* -* Return: 1 when device is in use, 0 otherwise. -*/ -int virtcrypto_dev_in_use (struct virtio_crypto *vcrypto_dev) -{ -return atomic_read (&vcrypto_dev->ref_count) !=0 ; -} -/* * virtcrypto_dev_get() - Increment vcrypto_dev reference count * @vcrypto_dev: Pointer to virtio crypto device.
Signature · 1 line
2.49.0
Quoted 8 lines · On 2025/6/14 8:05, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
virtcrypto_devmgr_get_first()andvirtcrypto_dev_in_use()were added in 2016 by
commitdbaf0624ffa5("crypto: add virtio-crypto driver")but have remained unused.
Quoted 7 lines
Remove them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/crypto/virtio/virtio_crypto_common.h | 2 -- drivers/crypto/virtio/virtio_crypto_mgr.c | 36 -------------------- 2 files changed, 38 deletions(-)
Reviewed-by Zenghui Yu <[email protected]>
Herbert Xu
maintainerQuoted 8 lines · On Sat, Jun 14, 2025 at 01:05:05AM +0100, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
virtcrypto_devmgr_get_first()andvirtcrypto_dev_in_use()were added in 2016 by
commitdbaf0624ffa5("crypto: add virtio-crypto driver")but have remained unused.
Quoted 7 lines
Remove them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/crypto/virtio/virtio_crypto_common.h | 2 -- drivers/crypto/virtio/virtio_crypto_mgr.c | 36 -------------------- 2 files changed, 38 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt