fbdev: tdfxfb: Fix potential divide by zero
PATCH 1/1 fbdev: tdfxfb: Fix potential divide by zero
Variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in tdfxfb_check_var. Similar crashes have happened in other fbdev drivers. We fix this by checking whether 'pixclock' is zero.
Signed-off-by Alex Guo <[email protected]>
--- drivers/video/fbdev/tdfxfb.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/video/fbdev/tdfxfb.c +3 -0
@@ -495,6 +495,9 @@ static int tdfxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)return -EINVAL ; } } + +if (var->pixclock <=KHZ2PICOS (par->max_pixclock)) + var->pixclock =KHZ2PICOS (par->max_pixclock) +1 ;if (PICOS2KHZ (var->pixclock) > par->max_pixclock) { DPRINTK("pixclock too high (%ldKHz)\n",
Signature · 1 line
2.34.1