drm/i915/guc: Enable CT_DEAD output in regular debug builds
Subsystems (2)
PATCH 1/1 drm/i915/guc: Enable CT_DEAD output in regular debug builds
From: John Harrison <[email protected]>
There is a sporadic failure to enable CTs ocurring in CI on one specific machine that can't be reproduced locally. The driver already supports dumping out a whole bunch of GuC related debug info on such a failure but only when the verbose GuC debug config option is enabled. It would be preferable to not enable all the verbose debug output. So just bump the CT_DEAD code to regular I915 debug level rather than GUC debug level, at least temporarily for CI.
To prevent excessive spam in other parts of CI, also add a check against doing a CT_DEAD dump during an error injection test. No point in dumping large amounts of 'why did this fail' info when the fail is deliberately induced.
--- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 13 ++++++++----- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +8 -5
@@ -13,7 +13,7 @@#include "intel_guc_ct.h" #include "intel_guc_print.h" -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG_GUC ) +#if IS_ENABLED (CONFIG_DRM_I915_DEBUG )enum {CT_DEAD_ALIVE =0 , CT_DEAD_SETUP,
@@ -44,7 +44,7 @@ static inline struct intel_guc *ct_to_guc(struct intel_guc_ct *ct)#define CT_ERROR (_ct, _fmt, ...) \ guc_err(ct_to_guc(_ct), "CT: " _fmt, ##__VA_ARGS__) -#ifdef CONFIG_DRM_I915_DEBUG_GUC +#ifdef CONFIG_DRM_I915_DEBUG #define CT_DEBUG (_ct, _fmt, ...) \ guc_dbg(ct_to_guc(_ct), "CT: " _fmt, ##__VA_ARGS__)#else
@@ -144,7 +144,7 @@ void intel_guc_ct_init_early(struct intel_guc_ct *ct)spin_lock_init (&ct->requests.lock);INIT_LIST_HEAD (&ct->requests.pending);INIT_LIST_HEAD (&ct->requests.incoming); -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG_GUC ) +#if IS_ENABLED (CONFIG_DRM_I915_DEBUG )INIT_WORK (&ct->dead_ct_worker, ct_dead_ct_worker_func);#endif INIT_WORK (&ct->requests.worker, ct_incoming_request_worker_func);
@@ -373,7 +373,7 @@ int intel_guc_ct_enable(struct intel_guc_ct *ct) ct->enabled = true; ct->stall_time =KTIME_MAX ; -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG_GUC ) +#if IS_ENABLED (CONFIG_DRM_I915_DEBUG ) ct->dead_ct_reported = false; ct->dead_ct_reason =CT_DEAD_ALIVE ;#endif
@@ -1377,7 +1377,7 @@ void intel_guc_ct_print_info(struct intel_guc_ct *ct, ct->ctbs.recv.desc->tail); } -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG_GUC ) +#if IS_ENABLED (CONFIG_DRM_I915_DEBUG )static void ct_dead_ct_worker_func (struct work_struct *w) { struct intel_guc_ct *ct = container_of(w, struct intel_guc_ct, dead_ct_worker);
@@ -1386,6 +1386,9 @@ static void ct_dead_ct_worker_func(struct work_struct *w)if (ct->dead_ct_reported)return ; +if (i915_error_injected ()) +return ; + ct->dead_ct_reported = true;guc_info (guc,"CTB is dead - reason=0x%X\n" , ct->dead_ct_reason);
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h +1 -1
@@ -97,7 +97,7 @@ struct intel_guc_ct {/** @stall_time: time of first time a CTB submission is stalled */ ktime_t stall_time; -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG_GUC ) +#if IS_ENABLED (CONFIG_DRM_I915_DEBUG )int dead_ct_reason;bool dead_ct_reported;struct work_struct dead_ct_worker;
Signature · 1 line
2.49.0
Patchwork
CI✗ i915.CI.BAT: failure for drm/i915/guc: Enable CT_DEAD output in regular debug builds
== Series Details ==
== Series Details ==
Series: drm/i915/guc: Enable CT_DEAD output in regular debug builds
URL : https://patchwork.freedesktop.org/series/150275/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16703 -> Patchwork_150275v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_150275v1 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_150275v1, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/index.html
Participating hosts (44 -> 42)
------------------------------
Missing (2): bat-arlh-2 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_150275v1:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_parallel@engines:
- bat-arls-6: [PASS][1] -> [INCOMPLETE][2] +3 other tests incomplete
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-arls-6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-arls-6/igt@[email protected]
* igt@gem_sync@basic-all:
- bat-twl-2: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-twl-2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-twl-2/igt@[email protected]
* igt@i915_selftest@live:
- bat-adlp-9: [PASS][5] -> [INCOMPLETE][6] +1 other test incomplete
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-adlp-9/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-adlp-9/igt@[email protected]
- bat-arls-5: [PASS][7] -> [INCOMPLETE][8] +1 other test incomplete
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-arls-5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-arls-5/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- bat-dg1-7: [PASS][9] -> [INCOMPLETE][10] +1 other test incomplete
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg1-7/igt@i915_selftest@live@gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg1-7/igt@i915_selftest@live@gem_contexts.html
- bat-twl-1: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-twl-1/igt@i915_selftest@live@gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-twl-1/igt@i915_selftest@live@gem_contexts.html
- bat-rplp-1: [PASS][13] -> [ABORT][14] +1 other test abort
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-rplp-1/igt@i915_selftest@live@gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-rplp-1/igt@i915_selftest@live@gem_contexts.html
- bat-adlp-11: [PASS][15] -> [ABORT][16] +1 other test abort
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-adlp-11/igt@i915_selftest@live@gem_contexts.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-adlp-11/igt@i915_selftest@live@gem_contexts.html
- bat-dg1-6: [PASS][17] -> [INCOMPLETE][18] +1 other test incomplete
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg1-6/igt@i915_selftest@live@gem_contexts.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg1-6/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@gt_timelines:
- bat-dg2-9: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-9/igt@i915_selftest@live@gt_timelines.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-9/igt@i915_selftest@live@gt_timelines.html
- bat-adlp-6: [PASS][21] -> [INCOMPLETE][22] +1 other test incomplete
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-adlp-6/igt@i915_selftest@live@gt_timelines.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-adlp-6/igt@i915_selftest@live@gt_timelines.html
- bat-twl-2: [PASS][23] -> [TIMEOUT][24] +1 other test timeout
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-twl-2/igt@i915_selftest@live@gt_timelines.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-twl-2/igt@i915_selftest@live@gt_timelines.html
- bat-dg2-11: [PASS][25] -> [INCOMPLETE][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-11/igt@i915_selftest@live@gt_timelines.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-11/igt@i915_selftest@live@gt_timelines.html
- bat-dg2-14: [PASS][27] -> [INCOMPLETE][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-14/igt@i915_selftest@live@gt_timelines.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-14/igt@i915_selftest@live@gt_timelines.html
- bat-atsm-1: [PASS][29] -> [INCOMPLETE][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-atsm-1/igt@i915_selftest@live@gt_timelines.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-atsm-1/igt@i915_selftest@live@gt_timelines.html
- bat-mtlp-9: [PASS][31] -> [INCOMPLETE][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-mtlp-9/igt@i915_selftest@live@gt_timelines.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-mtlp-9/igt@i915_selftest@live@gt_timelines.html
- bat-mtlp-8: [PASS][33] -> [INCOMPLETE][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-mtlp-8/igt@i915_selftest@live@gt_timelines.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-mtlp-8/igt@i915_selftest@live@gt_timelines.html
- bat-dg2-8: [PASS][35] -> [INCOMPLETE][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-8/igt@i915_selftest@live@gt_timelines.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-8/igt@i915_selftest@live@gt_timelines.html
- bat-arlh-3: [PASS][37] -> [INCOMPLETE][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-arlh-3/igt@i915_selftest@live@gt_timelines.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-arlh-3/igt@i915_selftest@live@gt_timelines.html
#### Warnings ####
* igt@i915_selftest@live:
- bat-dg2-8: [ABORT][39] ([i915#14429]) -> [INCOMPLETE][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-8/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-8/igt@[email protected]
- bat-dg2-9: [DMESG-FAIL][41] ([i915#12061]) -> [INCOMPLETE][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-9/igt@[email protected]
- bat-dg2-11: [DMESG-FAIL][43] ([i915#12061]) -> [INCOMPLETE][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-11/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-11/igt@[email protected]
- bat-atsm-1: [DMESG-FAIL][45] ([i915#12061] / [i915#13929]) -> [INCOMPLETE][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-atsm-1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-atsm-1/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_16703 and Patchwork_150275v1:
### New IGT tests (1) ###
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-7:
- Statuses : 1 pass(s)
- Exec time: [0.68] s
Known issues
------------
Here are the changes found in Patchwork_150275v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests@dma_fence_chain:
- bat-twl-2: NOTRUN -> [INCOMPLETE][47] ([i915#12904]) +1 other test incomplete
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-twl-2/igt@dmabuf@all-tests@dma_fence_chain.html
* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][48] -> [INCOMPLETE][49] ([i915#14393])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-mtlp-8/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-mtlp-8/igt@[email protected]
- bat-twl-1: [PASS][50] -> [INCOMPLETE][51] ([i915#14096])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-twl-1/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-twl-1/igt@[email protected]
- bat-mtlp-9: [PASS][52] -> [INCOMPLETE][53] ([i915#14402])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-mtlp-9/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-mtlp-9/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@load:
- bat-mtlp-9: [DMESG-WARN][54] ([i915#13494]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-mtlp-9/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-mtlp-9/igt@[email protected]
* igt@i915_selftest@live@workarounds:
- bat-dg2-9: [DMESG-FAIL][56] ([i915#12061]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-9/igt@i915_selftest@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-9/igt@i915_selftest@[email protected]
- bat-dg2-11: [DMESG-FAIL][58] ([i915#12061]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-11/igt@i915_selftest@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-11/igt@i915_selftest@[email protected]
- bat-dg2-14: [DMESG-FAIL][60] ([i915#12061]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-14/igt@i915_selftest@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-14/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@i915_selftest@live:
- bat-arlh-3: [DMESG-FAIL][62] ([i915#14243]) -> [INCOMPLETE][63] ([i915#14393])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-arlh-3/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-arlh-3/igt@[email protected]
- bat-dg2-14: [DMESG-FAIL][64] ([i915#12061]) -> [INCOMPLETE][65] ([i915#14393])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16703/bat-dg2-14/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/bat-dg2-14/igt@[email protected]
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
[i915#13494]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13494
[i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
[i915#14096]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14096
[i915#14243]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14243
[i915#14393]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14393
[i915#14402]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14402
[i915#14429]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14429
Build changes
-------------
* Linux: CI_DRM_16703 -> Patchwork_150275v1
CI-20190529: 20190529
CI_DRM_16703: 4d016d6e602638e0ebc3895331224e057508c07a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8411: d5b5d2bb4f8795a98ea58376a128b74f654b7ec1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_150275v1: 4d016d6e602638e0ebc3895331224e057508c07a @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150275v1/index.html