net: ethernet: mtk_eth_soc: support named IRQs
Subsystems (4)
PATCH 1/1 net: ethernet: mtk_eth_soc: support named IRQs
From: Frank Wunderlich <[email protected]>
Add named interrupts and keep index based fallback for exiting devicetrees.
Currently only rx and tx IRQs are defined to be used with mt7988, but later extended with RSS/LRO support.
--- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 24 +++++++++++++-------- 1 file changed, 15 insertions(+), 9 deletions(-)
drivers/net/ethernet/mediatek/mtk_eth_soc.c +15 -9
@@ -5106,17 +5106,23 @@ static int mtk_probe(struct platform_device *pdev) } } -for (i =0 ; i <3 ; i++) { -if (MTK_HAS_CAPS (eth->soc->caps,MTK_SHARED_INT ) && i >0 ) - eth->irq[i] = eth->irq[0 ]; -else - eth->irq[i] =platform_get_irq (pdev, i); -if (eth->irq[i] <0 ) { -dev_err (&pdev->dev,"no IRQ%d resource found\n" , i); - err = -ENXIO ; - goto err_wed_exit; + eth->irq[1 ] =platform_get_irq_byname (pdev,"tx" ); + eth->irq[2 ] =platform_get_irq_byname (pdev,"rx" ); +if (eth->irq[1 ] <0 || eth->irq[2 ] <0 ) { +for (i =0 ; i <3 ; i++) { +if (MTK_HAS_CAPS (eth->soc->caps,MTK_SHARED_INT ) && i >0 ) + eth->irq[i] = eth->irq[0 ]; +else + eth->irq[i] =platform_get_irq (pdev, i); + +if (eth->irq[i] <0 ) { +dev_err (&pdev->dev,"no IRQ%d resource found\n" , i); + err = -ENXIO ; + goto err_wed_exit; + } } } +for (i =0 ; i <ARRAY_SIZE (eth->clks); i++) { eth->clks[i] =devm_clk_get (eth->dev, mtk_clks_source_name[i]);
Signature · 1 line
2.43.0
Quoted 36 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
Add named interrupts and keep index based fallback for exiting devicetrees.
Currently only rx and tx IRQs are defined to be used with mt7988, but later extended with RSS/LRO support.
Signed-off-by Frank Wunderlich <[email protected]>--- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 24 +++++++++++++-------- 1 file changed, 15 insertions(+), 9 deletions(-)drivers/net/ethernet/mediatek/mtk_eth_soc.c +7
-9@@ -5106,17 +5106,23 @@ static int mtk_probe(struct platform_device *pdev) } } -for (i =0 ; i <3 ; i++) { -if (MTK_HAS_CAPS (eth->soc->caps,MTK_SHARED_INT ) && i >0 ) - eth->irq[i] = eth->irq[0 ]; -else - eth->irq[i] =platform_get_irq (pdev, i); -if (eth->irq[i] <0 ) { -dev_err (&pdev->dev,"no IRQ%d resource found\n" , i); - err = -ENXIO ; - goto err_wed_exit; + eth->irq[1 ] =platform_get_irq_byname (pdev,"tx" ); + eth->irq[2 ] =platform_get_irq_byname (pdev,"rx" ); +if (eth->irq[1 ] <0 || eth->irq[2 ] <0 ) { +for (i =0 ; i <3 ; i++) { +if (MTK_HAS_CAPS (eth->soc->caps,MTK_SHARED_INT ) && i >0 ) + eth->irq[i] = eth->irq[0 ]; +else
drivers/net/ethernet/mediatek/mtk_eth_soc.c static int mtk_probe(struct platform_device *pdev) · line 5125
Quoted 10 lines
drivers/net/ethernet/mediatek/mtk_eth_soc.c +8
-0+ eth->irq[i] =platform_get_irq (pdev, i); + +if (eth->irq[i] <0 ) { +dev_err (&pdev->dev,"no IRQ%d resource found\n" , i); + err = -ENXIO ; + goto err_wed_exit; + } } } +
Thanks Frank,
The above looks correct to me. But I do think it could be improved by moving the irq lookup logic - either the unnamed portion or all of it - into a helper.
That suggestion notwithstanding,
Quoted 7 lines
drivers/net/ethernet/mediatek/mtk_eth_soc.c +0
-0for (i =0 ; i <ARRAY_SIZE (eth->clks); i++) { eth->clks[i] =devm_clk_get (eth->dev, mtk_clks_source_name[i]);Signature · 1 line
2.43.0