Skip to contentSkip to conversation

virtio-gpu: Fix missing driver conformance file

PATCH In review Parav Pandit 2 participants 7 messages Jun 14, 2025 – Jul 8, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-gpu: Fix missing driver conformance file

Cited patch in the fixes tag missed to include the driver-conformance file. Add it.

Fixes f52fb20cbe38 ("virtio-gpu: support blob alignment information")
---
 device-types/gpu/driver-conformance.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 device-types/gpu/driver-conformance.tex
device-types/gpu/driver-conformance.tex new file +8 -0
new file mode 100644
index 0000000..9ef708e
@@ -0,0 +1,8 @@
+\conformance{\subsection}{GPU Driver Conformance}\label{sec:Conformance / Driver Conformance / GPU Driver Conformance}
+
+A GPU Driver MUST conform to the following normative statements:
+
+\begin{itemize}
+\item \ref{drivernormative:Device Types / GPU Device / Device Operation / Device Operation: controlq}
+\item \ref{drivernormative:Device Types / GPU Device / Device Operation / Device Operation: controlq (3d)}
+\end{itemize}
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Parav Pandit

Cited patch in the fixes tag missed to include the driver-conformance file. Add it.

Fixes f52fb20cbe38 ("virtio-gpu: support blob alignment information")
---
 device-types/gpu/driver-conformance.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 device-types/gpu/driver-conformance.tex
#2 lore raw

Hi ,

Quoted 15 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 16 June 2025 04:00 PM

Quoted 10 lines · Parav Pandit

Cited patch in the fixes tag missed to include the driver-conformance file. Add it.

Fixes f52fb20cbe38 ("virtio-gpu: support blob alignment information")
---
 device-types/gpu/driver-conformance.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 device-types/gpu/driver-conformance.tex
Quoted 1 line

Can you please raise the voting ballot for this patch which fixes https://github.com/oasis-tcs/virtio-spec/issues/223?
I didn't create a new github issue as 223 is open and its half written patches are not merged.
It is fixed with this patch.

#3 lore raw
Quoted 17 lines · Parav Pandit

Hi ,

Quoted 15 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 16 June 2025 04:00 PM

Quoted 10 lines · Parav Pandit

Cited patch in the fixes tag missed to include the driver-conformance file. Add it.

Fixes f52fb20cbe38 ("virtio-gpu: support blob alignment information")
---
 device-types/gpu/driver-conformance.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 device-types/gpu/driver-conformance.tex
Quoted 6 lines
Quoted 1 line

Can you please raise the voting ballot for this patch which fixes https://github.com/oasis-tcs/virtio-spec/issues/223?
I didn't create a new github issue as 223 is open and its half written patches are not merged.
It is fixed with this patch.

Why is it still open if the ballot has been voted?

Thanks, Matias

#4 lore raw
Quoted 28 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 08 July 2025 01:36 PM

Quoted 18 lines · Parav Pandit

Hi ,

Quoted 16 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 16 June 2025 04:00 PM

Quoted 11 lines · Parav Pandit

Cited patch in the fixes tag missed to include the driver-conformance file. Add it.

Fixes f52fb20cbe38 ("virtio-gpu: support blob alignment

information")

---
 device-types/gpu/driver-conformance.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 device-types/gpu/driver-conformance.tex
Quoted 3 lines
Quoted 1 line

Can you please raise the voting ballot for this patch which fixes

https://github.com/oasis-tcs/virtio-spec/issues/223?

Quoted 8 lines
Quoted 1 line

I didn't create a new github issue as 223 is open and its half written patches

are not merged.

Quoted 2 lines

It is fixed with this patch.

Why is it still open if the ballot has been voted?

Thanks, Matias

I dint merge because basic makepdf etc scripts fail without this proposed fix.
And this proposed fix is non editorial in my view.
So this proposed patch needs vote. Once voting passes, I will merge the original patch + this fix for the same issue 223.

#5 lore raw
Quoted 33 lines · Parav Pandit
Quoted 33 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 08 July 2025 01:36 PM

Quoted 18 lines · Parav Pandit

Hi ,

Quoted 16 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 16 June 2025 04:00 PM

Quoted 11 lines · Parav Pandit

Cited patch in the fixes tag missed to include the driver-conformance file. Add it.

Fixes f52fb20cbe38 ("virtio-gpu: support blob alignment

information")

---
 device-types/gpu/driver-conformance.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 device-types/gpu/driver-conformance.tex
Quoted 3 lines
Quoted 1 line

Can you please raise the voting ballot for this patch which fixes

https://github.com/oasis-tcs/virtio-spec/issues/223?

Quoted 1 line

I didn't create a new github issue as 223 is open and its half written patches

are not merged.

Quoted 2 lines

It is fixed with this patch.

Quoted 8 lines
Quoted 3 lines

Why is it still open if the ballot has been voted?

Thanks, Matias

I dint merge because basic makepdf etc scripts fail without this proposed fix.
And this proposed fix is non editorial in my view.
So this proposed patch needs vote. Once voting passes, I will merge the original patch + this fix for the same issue 223.

I see, since it looks like a non editorial change, should we open a ballot for that? Can't we just merge it?

Matias

#6 lore raw
Quoted 43 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 08 July 2025 01:58 PM

Quoted 38 lines · Parav Pandit
Quoted 37 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 08 July 2025 01:36 PM

Quoted 18 lines · Parav Pandit

Hi ,

Quoted 16 lines

From: Matias Ezequiel Vara Larsen <[email protected]>
Sent: 16 June 2025 04:00 PM

Quoted 11 lines · Parav Pandit

Cited patch in the fixes tag missed to include the driver-conformance file. Add it.

Fixes f52fb20cbe38 ("virtio-gpu: support blob alignment

information")

---
 device-types/gpu/driver-conformance.tex | 8 ++++++++
 1 file changed, 8 insertions(+)  create mode 100644

device-types/gpu/driver-conformance.tex

Quoted 3 lines
Quoted 1 line

Can you please raise the voting ballot for this patch which fixes

https://github.com/oasis-tcs/virtio-spec/issues/223?

Quoted 2 lines

I didn't create a new github issue as 223 is open and its half written patches

are not merged.

Quoted 2 lines

It is fixed with this patch.

Why is it still open if the ballot has been voted?

Thanks, Matias

Quoted 9 lines
Quoted 3 lines

I dint merge because basic makepdf etc scripts fail without this proposed fix. And this proposed fix is non editorial in my view.
So this proposed patch needs vote. Once voting passes, I will merge the

original patch + this fix for the same issue 223.

Quoted 1 line

I see, since it looks like a non editorial change, should we open a ballot for that? Can't we just merge it?

Previously general guidance was, if in doubt ask for vote. 😊 So, I will let Michael and Cornelia to guide for this one.