Skip to contentSkip to conversation

two tegra drier tracing patches

PATCH New Ben Dooks 1 participant 3 messages Jun 16, 2025

Subsystems (3)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

I added some tracing to the tegra-mc and the bpmp driver which the tegra-mc uses. This might be useful to other people so sending these for review.

[PATCH 1/2] memory: tegra-mc: add tracepoints for tegra mc tracing [PATCH 2/2] drivers/firware/tegra: add tracing to bpmp code

author
#1 lore raw

PATCH 1/2 memory: tegra-mc: add tracepoints for tegra mc tracing

Add trace points to allow tracing of how the tegra_mc driver is being called.

---
 drivers/memory/tegra/mc.c       | 26 +++++++------
 include/trace/events/tegra_mc.h | 69 +++++++++++++++++++++++++++++++++
 2 files changed, 84 insertions(+), 11 deletions(-)
 create mode 100644 include/trace/events/tegra_mc.h
drivers/memory/tegra/mc.c +15 -11
index bd5b58f1fd42..256cf0d0aa2d 100644
@@ -21,6 +21,9 @@
 
 #include "mc.h"
 
+#define CREATE_TRACE_POINTS
+#include <trace/events/tegra_mc.h>
+
 static const struct of_device_id tegra_mc_of_match[] = {
 #ifdef CONFIG_ARCH_TEGRA_2x_SOC
 	{ .compatible = "nvidia,tegra20-mc-gart", .data = &tegra20_mc_soc },
@@ -210,6 +213,8 @@ static int tegra_mc_hotreset_assert(struct reset_controller_dev *rcdev,
 	int retries = 500;
 	int err;
 
+	trace_tegra_mc_hotreset(mc->dev, id, true);
+
 	rst = tegra_mc_reset_find(mc, id);
 	if (!rst)
 		return -ENODEV;
@@ -269,6 +274,8 @@ static int tegra_mc_hotreset_deassert(struct reset_controller_dev *rcdev,
 	const struct tegra_mc_reset *rst;
 	int err;
 
+	trace_tegra_mc_hotreset(mc->dev, id, false);
+
 	rst = tegra_mc_reset_find(mc, id);
 	if (!rst)
 		return -ENODEV;
@@ -583,7 +590,7 @@ irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
 	for_each_set_bit(bit, &status, 32) {
 		const char *error = tegra_mc_status_names[bit] ?: "unknown";
 		const char *client = "unknown", *desc;
-		const char *direction, *secure;
+		bool secure, write;
 		u32 status_reg, addr_reg;
 		u32 intmask = BIT(bit);
 		phys_addr_t addr = 0;
@@ -652,15 +659,8 @@ irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
 		}
 #endif
 
-		if (value & MC_ERR_STATUS_RW)
-			direction = "write";
-		else
-			direction = "read";
-
-		if (value & MC_ERR_STATUS_SECURITY)
-			secure = "secure ";
-		else
-			secure = "";
+		write = value & MC_ERR_STATUS_RW;
+		secure = value & MC_ERR_STATUS_SECURITY;
 
 		id = value & mc->soc->client_id_mask;
 
@@ -710,8 +710,12 @@ irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
 			value = mc_readl(mc, addr_reg);
 		addr |= value;
 
+		trace_tegra_mc_err(mc->dev, client, secure, write, addr,
+				   error, desc, perm);
+
 		dev_err_ratelimited(mc->dev, "%s: %s%s @%pa: %s (%s%s)\n",
-				    client, secure, direction, &addr, error,
+				    client, secure ? "secure" : "",
+				    write ? "write" : "read", &addr, error,
 				    desc, perm);
 	}
 
include/trace/events/tegra_mc.h new file +69 -0

69 lines not on this page · raw message

Signature · 1 line
2.37.2.352.g3c44437643
author
#2 lore raw

PATCH 2/2 drivers/firware/tegra: add tracing to bpmp code

In reply to Ben Dooks

Add trace points to the communications with the bpmp

---
 drivers/firmware/tegra/bpmp.c     |  16 +++-
 include/trace/events/tegra_bpmp.h | 140 ++++++++++++++++++++++++++++++
 2 files changed, 155 insertions(+), 1 deletion(-)
 create mode 100644 include/trace/events/tegra_bpmp.h
drivers/firmware/tegra/bpmp.c +15 -1
index c3a1dc344961..b7c005990269 100644
@@ -20,6 +20,9 @@
 
 #include "bpmp-private.h"
 
+#define CREATE_TRACE_POINTS
+#include <trace/events/tegra_bpmp.h>
+
 #define MSG_ACK		BIT(0)
 #define MSG_RING	BIT(1)
 #define TAG_SZ		32
@@ -227,6 +230,7 @@ static ssize_t tegra_bpmp_channel_read(struct tegra_bpmp_channel *channel,
 unlock:
 	up(&bpmp->threaded.lock);
 
+	trace_tegra_bpmp_channel_read(channel, data, size, ret, err);
 	return err;
 }
 
@@ -240,6 +244,8 @@ static ssize_t __tegra_bpmp_channel_write(struct tegra_bpmp_channel *channel,
 	if (data && size > 0)
 		tegra_bpmp_mb_write(&channel->ob, data, size);
 
+	trace_tegra_bpmp_channel_write(channel, mrq, flags, data, size);
+
 	return tegra_bpmp_post_request(channel);
 }
 
@@ -350,8 +356,12 @@ int tegra_bpmp_transfer_atomic(struct tegra_bpmp *bpmp,
 	if (err < 0)
 		return err;
 
-	return __tegra_bpmp_channel_read(channel, msg->rx.data, msg->rx.size,
+	err =  __tegra_bpmp_channel_read(channel, msg->rx.data, msg->rx.size,
 					 &msg->rx.ret);
+
+	trace_tegra_bpmp_channel_read(channel, msg->rx.data, msg->rx.size,
+				      &msg->rx.ret, err);
+	return err;
 }
 EXPORT_SYMBOL_GPL(tegra_bpmp_transfer_atomic);
 
@@ -368,6 +378,8 @@ int tegra_bpmp_transfer(struct tegra_bpmp *bpmp,
 	if (!tegra_bpmp_message_valid(msg))
 		return -EINVAL;
 
+	trace_tegra_bpmp_transfer(bpmp, msg);
+
 	if (bpmp->suspended) {
 		/* Reset BPMP IPC channels during resume based on flags passed */
 		if (msg->flags & TEGRA_BPMP_MESSAGE_RESET)
@@ -812,6 +824,7 @@ static int __maybe_unused tegra_bpmp_suspend(struct device *dev)
 {
 	struct tegra_bpmp *bpmp = dev_get_drvdata(dev);
 
+	trace_tegra_bpmp_pm(bpmp, true);
 	bpmp->suspended = true;
 
 	return 0;
@@ -821,6 +834,7 @@ static int __maybe_unused tegra_bpmp_resume(struct device *dev)
 {
 	struct tegra_bpmp *bpmp = dev_get_drvdata(dev);
 
+	trace_tegra_bpmp_pm(bpmp, false);
 	bpmp->suspended = false;
 
 	if (bpmp->soc->ops->resume)
include/trace/events/tegra_bpmp.h new file +140 -0

140 lines not on this page · raw message

Signature · 1 line
2.37.2.352.g3c44437643