Skip to contentSkip to conversation

s390/boot: use the full title of the manual for facility bits

PATCH In review Xose Vazquez Perez 3 participants 4 messages Jun 16, 2025 – Jul 3, 2025 s390

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390/boot: use the full title of the manual for facility bits

Also indicate the name of the section where they are listed, because it has a length of 2124 pages:
z/Architecture Principles of Operation - Facility Indications

The current version is: Fourteenth Edition (May, 2022) SA22-7832-13

Cc Heiko Carstens <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
Cc Vasily Gorbik <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
Cc Alexander Gordeev <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
Cc Christian Borntraeger <[email protected]> (reviewer:S390 ARCHITECTURE)
Cc Sven Schnelle <[email protected]> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
Cc S390 ML <[email protected]> (open list:S390 ARCHITECTURE)
---
 arch/s390/boot/als.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/boot/als.c +1 -1
index 79afb5fa7f1f..7d4cec1975c6 100644
@@ -65,7 +65,7 @@ static void facility_mismatch(void)
 	boot_emerg("The Linux kernel requires more recent processor hardware\n");
 	boot_emerg("Detected machine-type number: %4x\n", id.machine);
 	print_missing_facilities();
-	boot_emerg("See Principles of Operations for facility bits\n");
+	boot_emerg("For facility bits, see: z/Architecture Principles of Operation - Facility Indications\n");
 	disabled_wait();
 }
 
Signature · 1 line
2.49.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 22 lines · Xose Vazquez Perez

Also indicate the name of the section where they are listed, because it has a length of 2124 pages:
z/Architecture Principles of Operation - Facility Indications

The current version is: Fourteenth Edition (May, 2022) SA22-7832-13

Cc Heiko Carstens <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
Cc Vasily Gorbik <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
Cc Alexander Gordeev <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
Cc Christian Borntraeger <[email protected]> (reviewer:S390 ARCHITECTURE)
Cc Sven Schnelle <[email protected]> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
Cc S390 ML <[email protected]> (open list:S390 ARCHITECTURE)
---
 arch/s390/boot/als.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/boot/als.c +0 -0
index 79afb5fa7f1f..7d4cec1975c6 100644

arch/s390/boot/als.c static void facility_mismatch(void) · line 68

Quoted 5 lines
arch/s390/boot/als.c +1 -1
@@ -65,7 +65,7 @@ static void facility_mismatch(void)
 	boot_emerg("The Linux kernel requires more recent processor hardware\n");
 	boot_emerg("Detected machine-type number: %4x\n", id.machine);
 	print_missing_facilities();
-	boot_emerg("See Principles of Operations for facility bits\n");
+	boot_emerg("For facility bits, see: z/Architecture Principles of Operation - Facility Indications\n");

Fine with me, but please let's shorten this to:

	boot_emerg("See z/Architecture Principles of Operation - Facility Indications\n");

No need to resend, I guess Alexander can change this if he agrees.

#2 lore raw
In reply to Xose Vazquez Perez
Quoted 13 lines · Xose Vazquez Perez

Also indicate the name of the section where they are listed, because it has a length of 2124 pages:
z/Architecture Principles of Operation - Facility Indications

The current version is: Fourteenth Edition (May, 2022) SA22-7832-13

Cc Heiko Carstens <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
Cc Vasily Gorbik <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
Cc Alexander Gordeev <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
Cc Christian Borntraeger <[email protected]> (reviewer:S390 ARCHITECTURE)
Cc Sven Schnelle <[email protected]> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
Cc S390 ML <[email protected]> (open list:S390 ARCHITECTURE)
Quoted 3 lines
---
 arch/s390/boot/als.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Reformatted the commit message and applied.

Thanks!

#3 lore raw
Quoted 18 lines · Alexander Gordeev
Quoted 13 lines · Xose Vazquez Perez

Also indicate the name of the section where they are listed, because it has a length of 2124 pages:
z/Architecture Principles of Operation - Facility Indications

The current version is: Fourteenth Edition (May, 2022) SA22-7832-13

Cc Heiko Carstens <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
Cc Vasily Gorbik <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
Cc Alexander Gordeev <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
Cc Christian Borntraeger <[email protected]> (reviewer:S390 ARCHITECTURE)
Cc Sven Schnelle <[email protected]> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
Cc S390 ML <[email protected]> (open list:S390 ARCHITECTURE)
Quoted 3 lines
---
  arch/s390/boot/als.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 1 line

Reformatted the commit message and applied.

For the record, there is a new version of the manual:
Fifteenth Edition (April, 2025) SA22-7832-14
https://www.ibm.com/docs/en/module_1678991624569/pdf/SA22-7832-14.pdf