Skip to contentSkip to conversation

Improvements and fixes to swat-tools

PATCH In review Antonin Godard 2 participants 6 messages Jun 17, 2025

lore
Share & tools
lore
#0 lore raw

cover Improvements and fixes to swat-tools

---
Antonin Godard (4):
main: fix --yes short flag
pokyciarchive: fetch tags with --tags
Add a b4 configuration file
README: add a contributing section

 .b4-config                |  3 +++
 README.md                 | 19 +++++++++++++++++++
 swattool/main.py          |  2 +-
 swattool/pokyciarchive.py |  2 +-
 4 files changed, 24 insertions(+), 2 deletions(-)

---
base-commit: 72997bc94167082b3767571f1833ac805cdcb4a4
change-id: 20250617-improvements-e5cbad7184b0

Best regards,

Signature · 1 line
Antonin Godard <[email protected]>
#1 lore raw

PATCH 1/4 main: fix --yes short flag

Should be '-y' for yes, not '-n'.

---
 swattool/main.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
swattool/main.py +1 -1
index ce09bd5..a101340 100755
@@ -383,7 +383,7 @@ def review_pending_failures(refresh: str,
 
 @maingroup.command()
 @_add_options(failures_list_options)
[email protected]('--yes', '-n', is_flag=True,
[email protected]('--yes', '-y', is_flag=True,
               help="Do not ask for confirmation for each failure")
 @click.argument('status',
                 type=click.Choice([str(s) for s in swatbotrest.TriageStatus],
Signature · 1 line
2.49.0
#2 lore raw

PATCH 2/4 pokyciarchive: fetch tags with --tags

In reply to Antonin Godard

Using 'refs/tags/*:refs/tags/*' for fetching the tags for a remote removes the previously fetched tags of the other remotes. '--tags' does not have that behavior.

---
 swattool/pokyciarchive.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
swattool/pokyciarchive.py +1 -1
index e464b37..93d8dc1 100644
@@ -45,7 +45,7 @@ def update(min_age: Optional[int] = None) -> None:
         repo.remotes.create("archive", ARCHIVE_GITURL)
 
     for remote in repo.remotes:
-        remote.fetch(remote.fetch_refspecs + ['refs/tags/*:refs/tags/*'])
+        remote.fetch(remote.fetch_refspecs + ['--tags'])
 
 
 def get_build_commits(buildname: str, basebranch: str = "master",
Signature · 1 line
2.49.0
#4 lore raw

PATCH 4/4 README: add a contributing section

In reply to Antonin Godard
---
 README.md | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
README.md +19 -0
index a7e6772..102e336 100644
@@ -94,3 +94,22 @@ Publish new local triage status to swatbot Django interface.
   additionally importing `readline`. We should either investigate the root cause
   of the issue or get rid of one of the modules.
   <https://github.com/IngoMeyer441/simple-term-menu/issues/98>
+
+# Contributing
+
+Please refer to our contributor guide here: https://docs.yoctoproject.org/contributor-guide/
+for full details on how to submit changes.
+
+As a quick guide, patches should be sent to [email protected]
+The git command to do that would be:
+
+```
+git send-email -M -1 --subject-prefix='swat-tools][PATCH' --to [email protected]
+```
+
+The 'To' header and prefix can be set as default for this repository:
+
+```
+git config sendemail.to [email protected]
+git config format.subjectPrefix 'swat-tools][PATCH'
+```
Signature · 1 line
2.49.0
#5 lore raw
In reply to Antonin Godard
Quoted 13 lines · Antonin Godard

---
Antonin Godard (4):
main: fix --yes short flag
pokyciarchive: fetch tags with --tags
Add a b4 configuration file
README: add a contributing section

 .b4-config                |  3 +++
 README.md                 | 19 +++++++++++++++++++
 swattool/main.py          |  2 +-
 swattool/pokyciarchive.py |  2 +-
 4 files changed, 24 insertions(+), 2 deletions(-)
Quoted 5 lines

---
base-commit: 72997bc94167082b3767571f1833ac805cdcb4a4
change-id: 20250617-improvements-e5cbad7184b0

Best regards,

Looks good, thanks!

I have merged the series.

Signature · 3 lines
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com