ata: ahci: Disallow LPM for Asus B550-F motherboard
PATCH 1/1 ata: ahci: Disallow LPM for Asus B550-F motherboard
Asus ROG STRIX B550-F GAMING (WI-FI) motherboard has problems on some SATA ports with at least one hard drive model (WDC WD20EFAX-68FB5N0) when LPM is enabled. Disabling LPM solves the issue.
---
I think we might include the comment about the non working drive model, as we have tested only one model and in principle this could also be an interoperation issue. If one would need to enable LPM for the motherboard and happens to have a working hard drive model, he/she would know why we have made the patch in the first place.
drivers/ata/ahci.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/ata/ahci.c +16 -0
@@ -1454,6 +1454,22 @@ static bool ahci_broken_lpm(struct pci_dev *pdev) }, /* 320 is broken, there is no known good version yet. */ }, + { +/* +* AMD 500 Series Chipset SATA Controller [1022:43eb] +* on this motherboard timouts on ports 5 and 6 +* when LPM enabled at least with WDC WD20EFAX-68FB5N0 +* hard drives. +*/ + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, + "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, + "ROG STRIX B550-F GAMING (WI-FI)"), + }, + /* 3621 is broken, there is no known good version yet. + */ + }, { }/* terminate list */ };const struct dmi_system_id *dmi =dmi_first_match (sysids);
Signature · 1 line
2.49.0
Damien Le Moal
maintainerQuoted 29 lines · Mikko Korhonen
Asus ROG STRIX B550-F GAMING (WI-FI) motherboard has problems on some SATA ports with at least one hard drive model (WDC WD20EFAX-68FB5N0) when LPM is enabled. Disabling LPM solves the issue.
Fixes 7627a0edef54 ("ata: ahci: Drop low power policy board type")Signed-off-by Mikko Korhonen <[email protected]>---
I think we might include the comment about the non working drive model, as we have tested only one model and in principle this could also be an interoperation issue. If one would need to enable LPM for the motherboard and happens to have a working hard drive model, he/she would know why we have made the patch in the first place.drivers/ata/ahci.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/ata/ahci.c +5
-0@@ -1454,6 +1454,22 @@ static bool ahci_broken_lpm(struct pci_dev *pdev) },/* 320 is broken, there is no known good version yet. */ }, + { +/* +* AMD 500 Series Chipset SATA Controller [1022:43eb] +* on this motherboard timouts on ports 5 and 6 +* when LPM enabled at least with WDC WD20EFAX-68FB5N0
drivers/ata/ahci.c static bool ahci_broken_lpm(struct pci_dev *pdev) · line 1471
Quoted 10 lines
drivers/ata/ahci.c +10
-0+* hard drives. +*/ + .matches = { +DMI_MATCH (DMI_BOARD_VENDOR , +"ASUSTeK COMPUTER INC." ), +DMI_MATCH (DMI_BOARD_NAME , + "ROG STRIX B550-F GAMING (WI-FI)"), + }, +/* 3621 is broken, there is no known good version yet. +*/
Please use the correct comment format:
/* * 3621 is broken and there is no known good version. */
Quoted 4 lines
drivers/ata/ahci.c +1
-0+ }, { }/* terminate list */ };const struct dmi_system_id *dmi =dmi_first_match (sysids);
Signature · 2 lines
Damien Le Moal Western Digital Research
Niklas Cassel
maintainerQuoted 17 lines · Damien Le Moal
Quoted 16 lines · Mikko Korhonen
Asus ROG STRIX B550-F GAMING (WI-FI) motherboard has problems on some SATA ports with at least one hard drive model (WDC WD20EFAX-68FB5N0) when LPM is enabled. Disabling LPM solves the issue.
Fixes 7627a0edef54 ("ata: ahci: Drop low power policy board type")Signed-off-by Mikko Korhonen <[email protected]>---
I think we might include the comment about the non working drive model, as we have tested only one model and in principle this could also be an interoperation issue. If one would need to enable LPM for the motherboard and happens to have a working hard drive model, he/she would know why we have made the patch in the first place.drivers/ata/ahci.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
Quoted 12 lines
drivers/ata/ahci.c static bool ahci_broken_lpm(struct pci_dev *pdev) · line 1460
Quoted 12 lines
drivers/ata/ahci.c +4
-0@@ -1454,6 +1454,22 @@ static bool ahci_broken_lpm(struct pci_dev *pdev) },/* 320 is broken, there is no known good version yet. */ }, + { +/* +* AMD 500 Series Chipset SATA Controller [1022:43eb] +* on this motherboard timouts on ports 5 and 6
s/timouts/timeouts/
Quoted 6 lines
drivers/ata/ahci.c static bool ahci_broken_lpm(struct pci_dev *pdev) · line 1466
Quoted 6 lines
drivers/ata/ahci.c +6
-0+* when LPM enabled at least with WDC WD20EFAX-68FB5N0 +* hard drives. +*/ + .matches = { +DMI_MATCH (DMI_BOARD_VENDOR , + "ASUSTeK COMPUTER INC."),
align to open parenthesis
Quoted 2 lines
drivers/ata/ahci.c static bool ahci_broken_lpm(struct pci_dev *pdev) · line 1468
Quoted 2 lines
drivers/ata/ahci.c +2
-0+DMI_MATCH (DMI_BOARD_NAME , + "ROG STRIX B550-F GAMING (WI-FI)"),
align to open parenthesis
Quoted 9 lines
drivers/ata/ahci.c static bool ahci_broken_lpm(struct pci_dev *pdev) · line 1471
Quoted 3 lines
drivers/ata/ahci.c +3
-0+ }, +/* 3621 is broken, there is no known good version yet. +*/ Please use the correct comment format:
/* * 3621 is broken and there is no known good version. */
I think having it a single line as:
/* 3621 is broken and there is no known good version. */
is fine, as it will be less than 80 columns, and matches the existing single line comments in the same table.
Anyway, I can fix these nits up when applying, no need to send a V2.
Mikko, thank you for your efforts in debugging and helping out with reviews.
Kind regards,
Niklas
Quoted 5 lines · Mikko Korhonen
Asus ROG STRIX B550-F GAMING (WI-FI) motherboard has problems on some SATA ports with at least one hard drive model (WDC WD20EFAX-68FB5N0) when LPM is enabled. Disabling LPM solves the issue.
Applied to libata/linux.git (for-6.16-fixes), thanks!
[1/1] ata: ahci: Disallow LPM for Asus B550-F motherboard
https://git.kernel.org/libata/linux/c/a7b3b77f
Kind regards,
Niklas