Skip to contentSkip to conversation

phy: qcom: m31-eusb2: drop registration printk

PATCH Applied Johan Hovold 3 participants 3 messages Jun 17, 2025 – Jun 27, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: qcom: m31-eusb2: drop registration printk

Drivers should generally be quiet on successful probe so drop the registration printk from the recently added M31 EUSB2 driver.

---
 drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 --
 1 file changed, 2 deletions(-)
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c +0 -2
index 9f02b8a78f6e..9b987911fcdb 100644
@@ -288,8 +288,6 @@ static int m31eusb2_phy_probe(struct platform_device *pdev)
 				     "failed to get repeater\n");
 
 	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
-	if (!IS_ERR(phy_provider))
-		dev_info(dev, "Registered M31 USB phy\n");
 
 	return PTR_ERR_OR_ZERO(phy_provider);
 }
Signature · 1 line
2.49.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Johan Hovold

Drivers should generally be quiet on successful probe so drop the registration printk from the recently added M31 EUSB2 driver.

---
  drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 --
  1 file changed, 2 deletions(-)
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c +0 -0
index 9f02b8a78f6e..9b987911fcdb 100644

drivers/phy/qualcomm/phy-qcom-m31-eusb2.c static int m31eusb2_phy_probe(struct platform_device *pdev) · line 293

Quoted 8 lines
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c +0 -2
@@ -288,8 +288,6 @@ static int m31eusb2_phy_probe(struct platform_device *pdev)
  				     "failed to get repeater\n");
 
  	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
-	if (!IS_ERR(phy_provider))
-		dev_info(dev, "Registered M31 USB phy\n");
 
  	return PTR_ERR_OR_ZERO(phy_provider);
  }
maintainer Applied
#2 lore raw
In reply to Johan Hovold
Quoted 4 lines · Johan Hovold

Drivers should generally be quiet on successful probe so drop the registration printk from the recently added M31 EUSB2 driver.

Applied, thanks!

[1/1] phy: qcom: m31-eusb2: drop registration printk

      commit: 2bff9083c1744dc8751ddc0844a65e3bee89f519

Best regards,

Signature · 1 line
~Vinod