Skip to contentSkip to conversation

hwmon: (corsair-cpro) Change dependency from HID to HIDRAW

PATCH In review [email protected] 2 participants 2 messages Jun 18, 2025 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (corsair-cpro) Change dependency from HID to HIDRAW

From: "Dee.H.Y" <[email protected]>

This patch updates the dependency of the CORSAIR_CPRO driver in the hwmon subsystem. Previously, the driver relied on HID, but now it depends on HIDRAW. This change is aligned with the implementation in the ccp_probe() function, where HID_CONNECT_HIDRAW is used, indicating that the HID raw interface is required for proper operation.

---
 drivers/hwmon/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/Kconfig +1 -1
index 08a3c863f80a..3f128cacb486 100644
@@ -475,7 +475,7 @@ config SENSORS_CHIPCAP2
 
 config SENSORS_CORSAIR_CPRO
 	tristate "Corsair Commander Pro controller"
-	depends on HID
+	depends on HIDRAW
 	help
 	  If you say yes here you get support for the Corsair Commander Pro
 	  controller.
Signature · 1 line
2.49.0
maintainer
#1 lore raw
Quoted 4 lines · On 6/18/25 00:28, [email protected] wrote:

From: "Dee.H.Y" <[email protected]>

This patch updates the dependency of the CORSAIR_CPRO driver in the hwmon subsystem. Previously, the driver relied on HID, but now it

From Documentation/process/submitting-patches.rst:

Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.

What is "previously" ? The driver always used HID_CONNECT_HIDRAW.

Either case, I do not think this patch is warranted. CONFIG_HIDRAW creates /dev/hidraw for use by applications. This driver does not need such an application to work. If you disagree, please provide logs showing that the driver does not work with CONFIG_HIDRAW=n.

Thanks,
Guenter

Quoted 22 lines

depends on HIDRAW. This change is aligned with the implementation in the ccp_probe() function, where HID_CONNECT_HIDRAW is used, indicating that the HID raw interface is required for proper operation.

---
  drivers/hwmon/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/Kconfig +1 -1
index 08a3c863f80a..3f128cacb486 100644
@@ -475,7 +475,7 @@ config SENSORS_CHIPCAP2
 
  config SENSORS_CORSAIR_CPRO
  	tristate "Corsair Commander Pro controller"
-	depends on HID
+	depends on HIDRAW
  	help
  	  If you say yes here you get support for the Corsair Commander Pro
  	  controller.