usb: cdnsp: do not disable slot for disabled slot
Subsystems (3)
PATCH 1/1 usb: cdnsp: do not disable slot for disabled slot
It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status.
--- drivers/usb/cdns3/cdnsp-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/cdns3/cdnsp-ring.c +3 -1
@@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev, u32 port_id) }if (port_id != old_port) { -cdnsp_disable_slot (pdev); +if (pdev->slot_id) +cdnsp_disable_slot (pdev); + pdev->active_port = port;cdnsp_enable_slot (pdev); }
Signature · 1 line
2.25.1
发件人: Peter Chen <[email protected]> 发送时间: 2025年6月18日 17:53
Quoted 8 lines
It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status.
Fixes 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRDDriver")
Suggested-by Hongliang Yang <[email protected]>Signed-off-by Peter Chen <[email protected]>
Quoted 22 lines
---
drivers/usb/cdns3/cdnsp-ring.c| 4 +++-1 file changed, 3 insertions(+), 1 deletion(-)drivers/usb/cdns3/cdnsp-ring.c +3
-1@@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev, u32 port_id) }if (port_id != old_port) { -cdnsp_disable_slot (pdev); +if (pdev->slot_id) +cdnsp_disable_slot (pdev); + pdev->active_port = port;cdnsp_enable_slot (pdev);}--
2.25.1
Greg KH
maintainerQuoted 10 lines · Peter Chen
It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status.
Fixes 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")Suggested-by Hongliang Yang <[email protected]>Signed-off-by Peter Chen <[email protected]>--- drivers/usb/cdns3/cdnsp-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Any reason this wasn't cc:ed the proper mailing lists?
Or is this a stable-kernel-only patch?
confused,
greg k-h
Quoted 16 lines · Greg KH
[Some people who received this message don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
EXTERNAL EMAIL
Quoted 10 lines · Peter Chen
It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status.
Fixes 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")Suggested-by Hongliang Yang <[email protected]>Signed-off-by Peter Chen <[email protected]>--- drivers/usb/cdns3/cdnsp-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 5 lines
Any reason this wasn't cc:ed the proper mailing lists?
Or is this a stable-kernel-only patch?
confused,
Sorry, Greg. This is internal review patch for upstream, I forgot to omit cc list when sending review. Please ignore it.
The formal upstream patch has already sent out to linux-usb mail list.
Signature · 2 lines
Best regards, Peter