mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available
Subsystems (2)
PATCH v2 1/1 mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available
The message "Error getting PHY irq. Use polling instead" is emitted when the mlxbf_gige driver is loaded by the kernel before the associated gpio-mlxbf driver, and thus the call to get the PHY IRQ fails since it is not yet available. The driver probe() must return -EPROBE_DEFER if acpi_dev_gpio_irq_get_by() returns the same.
--- drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c +4 -2
@@ -447,8 +447,10 @@ static int mlxbf_gige_probe(struct platform_device *pdev) priv->llu_plu_irq =platform_get_irq (pdev,MLXBF_GIGE_LLU_PLU_INTR_IDX ); phy_irq =acpi_dev_gpio_irq_get_by (ACPI_COMPANION (&pdev->dev),"phy" ,0 ); -if (phy_irq <0 ) { -dev_err (&pdev->dev,"Error getting PHY irq. Use polling instead" ); +if (phy_irq == -EPROBE_DEFER ) { + err = -EPROBE_DEFER ; + goto out; + }else if (phy_irq <0 ) { phy_irq =PHY_POLL ; }
Signature · 1 line
2.43.2
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 18 Jun 2025 13:59:02 +0000 you wrote:
The message "Error getting PHY irq. Use polling instead" is emitted when the
mlxbf_gigedriver is loaded by the kernel before the associated gpio-mlxbf driver, and thus the call to get the PHY IRQ fails since it is not yet available. The driverprobe()must return -EPROBE_DEFER ifacpi_dev_gpio_irq_get_by()returns the same.[...]
Here is the summary with links:
- [net,v2] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available
https://git.kernel.org/netdev/net/c/e7ea5f5b1858
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html