Skip to contentSkip to conversation

media: vsp1: Add missing export.h

PATCH In review Jacopo Mondi 2 participants 2 messages Jun 18, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: vsp1: Add missing export.h

As reported by the Kernel Test Robot, the newly merged vspx driver exports a few symbols but doesn't include the export.h header.

While at it, include the header file in vsp1_drm.c which exports symbols as well.

---
Add missing export.h header as reported by kernel test robot <[email protected]>

Can this patch be fast-tracked to ensure it lands with the one that introduces the vspx driver ?

---
 drivers/media/platform/renesas/vsp1/vsp1_drm.c  | 1 +
 drivers/media/platform/renesas/vsp1/vsp1_vspx.c | 1 +
 2 files changed, 2 insertions(+)
drivers/media/platform/renesas/vsp1/vsp1_drm.c +1 -0
index fe55e8747b05aa351c1547469f9cbbe2b6d25408..15d266439564e2317dbc380ef04d2b15ae899852 100644
@@ -9,6 +9,7 @@
 
 #include <linux/device.h>
 #include <linux/dma-mapping.h>
+#include <linux/export.h>
 #include <linux/slab.h>
 
 #include <media/media-entity.h>
drivers/media/platform/renesas/vsp1/vsp1_vspx.c +1 -0
index 6551d63ba387a05c932d2e557bd0ae5f8810acc7..a754b92232bd57f1b4cd3f9e7903f0b5da5c5c57 100644
@@ -13,6 +13,7 @@
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/dma-mapping.h>
+#include <linux/export.h>
 #include <linux/list.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>

---
base-commit: 642b70d526ab8daa8f256dfc1eb6bf27c3290cc6
change-id: 20250618-vspx-include-export-84379a99bf59

Best regards,

Signature · 1 line
Jacopo Mondi <[email protected]>
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Jacopo,

Quoted 9 lines · Jacopo Mondi

As reported by the Kernel Test Robot, the newly merged vspx driver exports a few symbols but doesn't include the export.h header.

While at it, include the header file in vsp1_drm.c which exports symbols as well.

Quoted 5 lines

---
Add missing export.h header as reported by kernel test robot <[email protected]>

Can this patch be fast-tracked to ensure it lands with the one that introduces the vspx driver ?

I'll include it in my next pull request for Renesas media drivers, either this week or the next.

Quoted 33 lines
---
 drivers/media/platform/renesas/vsp1/vsp1_drm.c  | 1 +
 drivers/media/platform/renesas/vsp1/vsp1_vspx.c | 1 +
 2 files changed, 2 insertions(+)
drivers/media/platform/renesas/vsp1/vsp1_drm.c +1 -0
index fe55e8747b05aa351c1547469f9cbbe2b6d25408..15d266439564e2317dbc380ef04d2b15ae899852 100644
@@ -9,6 +9,7 @@
 
 #include <linux/device.h>
 #include <linux/dma-mapping.h>
+#include <linux/export.h>
 #include <linux/slab.h>
 
 #include <media/media-entity.h>
drivers/media/platform/renesas/vsp1/vsp1_vspx.c +1 -1
index 6551d63ba387a05c932d2e557bd0ae5f8810acc7..a754b92232bd57f1b4cd3f9e7903f0b5da5c5c57 100644
@@ -13,6 +13,7 @@
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/dma-mapping.h>
+#include <linux/export.h>
 #include <linux/list.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 
---

base-commit: 642b70d526ab8daa8f256dfc1eb6bf27c3290cc6
change-id: 20250618-vspx-include-export-84379a99bf59

Signature · 3 lines
Regards,

Laurent Pinchart