media: venus: hfi: explicitly release IRQ during teardown
Subsystems (4)
PATCH v2 1/1 media: venus: hfi: explicitly release IRQ during teardown
Ensure the IRQ is disabled - and all pending handlers completed - before dismantling the interrupt routing and clearing related pointers.
This prevents any possibility of the interrupt triggering after the handler context has been invalidated.
---
v2:
disable the handler and block until complete. allow devres to release and free the allocated irq
drivers/media/platform/qcom/venus/hfi_venus.c | 1 + 1 file changed, 1 insertion(+)
drivers/media/platform/qcom/venus/hfi_venus.c +1 -0
@@ -1678,6 +1678,7 @@ void venus_hfi_destroy(struct venus_core *core)venus_interface_queues_release (hdev);mutex_destroy (&hdev->lock);kfree (hdev); +disable_irq (core->irq); core->ops =NULL ; }
Signature · 1 line
2.34.1
Quoted 22 lines · Jorge Ramirez-Ortiz
Ensure the IRQ is disabled - and all pending handlers completed - before dismantling the interrupt routing and clearing related pointers.
This prevents any possibility of the interrupt triggering after the handler context has been invalidated.
Fixes d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files")Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
v2:
disable the handler and block until complete. allow devres to release and free the allocated irqdrivers/media/platform/qcom/venus/hfi_venus.c | 1 + 1 file changed, 1 insertion(+)drivers/media/platform/qcom/venus/hfi_venus.c +0
-0
drivers/media/platform/qcom/venus/hfi_venus.c void venus_hfi_destroy(struct venus_core *core) · line 1684
Quoted 7 lines
drivers/media/platform/qcom/venus/hfi_venus.c +1
-0@@ -1678,6 +1678,7 @@ void venus_hfi_destroy(struct venus_core *core)venus_interface_queues_release (hdev);mutex_destroy (&hdev->lock);kfree (hdev); +disable_irq (core->irq); core->ops =NULL ; }
Quoted 22 lines · Jorge Ramirez-Ortiz
Ensure the IRQ is disabled - and all pending handlers completed - before dismantling the interrupt routing and clearing related pointers.
This prevents any possibility of the interrupt triggering after the handler context has been invalidated.
Fixes d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files")Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
v2:
disable the handler and block until complete. allow devres to release and free the allocated irqdrivers/media/platform/qcom/venus/hfi_venus.c | 1 + 1 file changed, 1 insertion(+)drivers/media/platform/qcom/venus/hfi_venus.c +0
-0
drivers/media/platform/qcom/venus/hfi_venus.c void venus_hfi_destroy(struct venus_core *core) · line 1684
Quoted 7 lines
drivers/media/platform/qcom/venus/hfi_venus.c +1
-0@@ -1678,6 +1678,7 @@ void venus_hfi_destroy(struct venus_core *core)venus_interface_queues_release (hdev);mutex_destroy (&hdev->lock);kfree (hdev); +disable_irq (core->irq); core->ops =NULL ; }