Skip to contentSkip to conversation

wifi: ath11k: Make read-only const array svc_id static const

PATCH Applied Colin Ian King 3 participants 3 messages Jun 19, 2025 – Jun 26, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wifi: ath11k: Make read-only const array svc_id static const

Don't populate the read-only array svc_id on the stack at run time, instead make it static const.

---
 drivers/net/wireless/ath/ath11k/htc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/htc.c +1 -1
index 23054ab29a5e..4571d01cc33d 100644
@@ -497,7 +497,7 @@ static u8 ath11k_htc_get_credit_allocation(struct ath11k_htc *htc,
 static int ath11k_htc_setup_target_buffer_assignments(struct ath11k_htc *htc)
 {
 	struct ath11k_htc_svc_tx_credits *serv_entry;
-	u32 svc_id[] = {
+	static const u32 svc_id[] = {
 		ATH11K_HTC_SVC_ID_WMI_CONTROL,
 		ATH11K_HTC_SVC_ID_WMI_CONTROL_MAC1,
 		ATH11K_HTC_SVC_ID_WMI_CONTROL_MAC2,
Signature · 1 line
2.49.0
Applied
#2 lore raw
In reply to Colin Ian King
Quoted 4 lines · Colin Ian King

Don't populate the read-only array svc_id on the stack at run time, instead make it static const.

Applied, thanks!

[1/1] wifi: ath11k: Make read-only const array svc_id static const

      commit: d8f07889e920493845fd628407ff0debbe96fa09

Best regards,

Signature · 1 line
Jeff Johnson <[email protected]>