wifi: brcmfmac: Make read-only array cfg_offset static const
PATCH 1/1 wifi: brcmfmac: Make read-only array cfg_offset static const
Don't populate the read-only array cfg_offset on the stack at run time, instead make it static const.
Signed-off-by Colin Ian King <[email protected]>
--- .../broadcom/brcm80211/brcmfmac/pcie.c | 24 ++++++++++--------- 1 file changed, 13 insertions(+), 11 deletions(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +13 -11
@@ -654,17 +654,19 @@ brcmf_pcie_select_core(struct brcmf_pciedev_info *devinfo, u16 coreid)static void brcmf_pcie_reset_device (struct brcmf_pciedev_info *devinfo) {struct brcmf_core *core; -u16 cfg_offset[] = {BRCMF_PCIE_CFGREG_STATUS_CMD , -BRCMF_PCIE_CFGREG_PM_CSR , -BRCMF_PCIE_CFGREG_MSI_CAP , -BRCMF_PCIE_CFGREG_MSI_ADDR_L , -BRCMF_PCIE_CFGREG_MSI_ADDR_H , -BRCMF_PCIE_CFGREG_MSI_DATA , -BRCMF_PCIE_CFGREG_LINK_STATUS_CTRL2 , -BRCMF_PCIE_CFGREG_RBAR_CTRL , -BRCMF_PCIE_CFGREG_PML1_SUB_CTRL1 , -BRCMF_PCIE_CFGREG_REG_BAR2_CONFIG , -BRCMF_PCIE_CFGREG_REG_BAR3_CONFIG }; +static const u16 cfg_offset[] = { +BRCMF_PCIE_CFGREG_STATUS_CMD , +BRCMF_PCIE_CFGREG_PM_CSR , +BRCMF_PCIE_CFGREG_MSI_CAP , +BRCMF_PCIE_CFGREG_MSI_ADDR_L , +BRCMF_PCIE_CFGREG_MSI_ADDR_H , +BRCMF_PCIE_CFGREG_MSI_DATA , +BRCMF_PCIE_CFGREG_LINK_STATUS_CTRL2 , +BRCMF_PCIE_CFGREG_RBAR_CTRL , +BRCMF_PCIE_CFGREG_PML1_SUB_CTRL1 , +BRCMF_PCIE_CFGREG_REG_BAR2_CONFIG , +BRCMF_PCIE_CFGREG_REG_BAR3_CONFIG + };u32 i;u32 val;u32 lsc;
Signature · 1 line
2.49.0
Quoted 2 lines · Colin Ian King
Don't populate the read-only array
cfg_offseton the stack at run time, instead make it static const.
Acked-by Arend van Spriel <[email protected]>
Quoted 4 lines
Signed-off-by Colin Ian King <[email protected]>---
.../broadcom/brcm80211/brcmfmac/pcie.c| 24 ++++++++++---------1 file changed, 13 insertions(+), 11 deletions(-)