Skip to contentSkip to conversation

bcachefs: Don't memcpy more than needed

PATCH Applied Alan Huang 2 participants 2 messages Jun 19, 2025

lore
Share & tools
lore

Alan Huang

author
#0 lore raw

PATCH 1/1 bcachefs: Don't memcpy more than needed

buf->u64s is all we used.

---
 fs/bcachefs/btree_update.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/btree_update.c +1 -1
index ee657b9f4b96..d9a17d523db1 100644
@@ -566,7 +566,7 @@ void *__bch2_trans_subbuf_alloc(struct btree_trans *trans,
 	if (buf->u64s)
 		memcpy(n,
 		       btree_trans_subbuf_base(trans, buf),
-		       buf->size * sizeof(u64));
+		       buf->u64s * sizeof(u64));
 	buf->base = (u64 *) n - (u64 *) trans->mem;
 	buf->size = new_size;
 
Signature · 1 line
2.48.1
#1 lore raw
Quoted 3 lines · Alan Huang

buf->u64s is all we used.

applied

Quoted 20 lines
---
 fs/bcachefs/btree_update.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/btree_update.c +1 -1
index ee657b9f4b96..d9a17d523db1 100644
@@ -566,7 +566,7 @@ void *__bch2_trans_subbuf_alloc(struct btree_trans *trans,
 	if (buf->u64s)
 		memcpy(n,
 		       btree_trans_subbuf_base(trans, buf),
-		       buf->size * sizeof(u64));
+		       buf->u64s * sizeof(u64));
 	buf->base = (u64 *) n - (u64 *) trans->mem;
 	buf->size = new_size;
 
Signature · 1 line
2.48.1