Skip to contentSkip to conversation

bcache-remove-unnecessary-select-min_heap.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Jun 20, 2025 Stable branch

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: bcache: remove unnecessary select MIN_HEAP
has been removed from the -mm tree. Its filename was
bcache-remove-unnecessary-select-min_heap.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Kuan-Wei Chiu <[email protected]>
Subject: bcache: remove unnecessary select MIN_HEAP
Date: Sun, 15 Jun 2025 04:23:53 +0800

After reverting the transition to the generic min heap library, bcache no longer depends on MIN_HEAP. The select entry can be removed to reduce code size and shrink the kernel's attack surface.

This change effectively reverts the bcache-related part of commit 92a8b224b833 ("lib/min_heap: introduce non-inline versions of min heap API functions").

This is part of a series of changes to address a performance regression caused by the use of the generic min_heap implementation.

As reported by Robert, bcache now suffers from latency spikes, with P100 (max) latency increasing from 600 ms to 2.4 seconds every 5 minutes. These regressions degrade bcache's effectiveness as a low-latency cache layer and lead to frequent timeouts and application stalls in production environments.

Fixes 866898efbb25 ("bcache: remove heap-related macros and switch to generic min_heap")
Fixes 92a8b224b833 ("lib/min_heap: introduce non-inline versions of min heap API functions")
Cc Ching-Chun (Jim) Huang <[email protected]>
Cc Kent Overstreet <[email protected]>

---

 drivers/md/bcache/Kconfig |    1 -
 1 file changed, 1 deletion(-)
drivers/md/bcache/Kconfig renamed from drivers/md/bcache/Kconfig~bcache-remove-unnecessary-select-min_heap +0 -1
@@ -5,7 +5,6 @@ config BCACHE
 	select BLOCK_HOLDER_DEPRECATED if SYSFS
 	select CRC64
 	select CLOSURES
-	select MIN_HEAP
 	help
 	Allows a block device to be used as cache for other devices; uses
 	a btree for indexing and the layout is optimized for SSDs.

_

Patches currently in -mm which might be from [email protected] are

lib-math-gcd-use-static-key-to-select-implementation-at-runtime.patch riscv-optimize-gcd-code-size-when-config_riscv_isa_zbb-is-disabled.patch riscv-optimize-gcd-performance-on-risc-v-without-zbb-extension.patch