Skip to contentSkip to conversation

drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check

PATCH Applied Bartosz Golaszewski 2 participants 3 messages Jun 20, 2025 – Jun 26, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check

From: Bartosz Golaszewski <[email protected]>

As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input lines"), the GPIO core makes sure values cannot be set on input lines. Remove the unnecessary check.

---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/bridge/ti-sn65dsi86.c +0 -5
index 78a50b947a08..3d0b4bc5129d 100644
@@ -1677,11 +1677,6 @@ static int ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset,
 {
 	struct ti_sn65dsi86 *pdata = gpiochip_get_data(chip);
 
-	if (!test_bit(offset, pdata->gchip_output)) {
-		dev_err(pdata->dev, "Ignoring GPIO set while input\n");
-		return -EPERM;
-	}
-
 	val &= 1;
 	return regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG,
 				  BIT(SN_GPIO_OUTPUT_SHIFT + offset),
Signature · 1 line
2.48.1
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input lines"), the GPIO core makes sure values cannot be set on input lines. Remove the unnecessary check.

---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 -----
 1 file changed, 5 deletions(-)
reviewer Applied
#2 lore raw

Hi,

Quoted 11 lines · Doug Anderson

Hi,

Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input lines"), the GPIO core makes sure values cannot be set on input lines. Remove the unnecessary check.

Quoted 6 lines
Quoted 4 lines
---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 -----
 1 file changed, 5 deletions(-)

Pushed to drm-misc-next:

[1/1] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check

      commit: bffc0692359f8d06d989657c00b274802a791692