perf/arm-cmn: reduce stack usage in arm_cmn_probe()
Subsystems (2)
PATCH 1/1 perf/arm-cmn: reduce stack usage in arm_cmn_probe()
From: Arnd Bergmann <[email protected]>
This function has a rather large stack usage, which triggers the warning limit with clang if I reduce the default to 1280 bytes:
drivers/perf/arm-cmn.c:2541:12: error: stack frame size (1312) exceeds limit (1280) in 'arm_cmn_probe' [-Werror,-Wframe-larger-than]
This is a combination of two problems:
- The arm_cmn_discover() function has some large local variables and gets inlined here by clang (but not gcc)
- The (struct pmu) assignment adds an extra copy of the pmu structure on the stack and does a memcpy() from that
Address the first one here by marking arm_cmn_discover() as noinline_for_stack, making clang behave more like gcc here. This gets it under the warning limit, though the total stack usage does not actually get reduced.
It would be nice to also change the way struct pmu is initialized, but I see that this is done consistently for all pmu drivers. Ideally the function pointers should be moved into a 'static const' structure per driver as this is done in most other subsystems.
--- drivers/perf/arm-cmn.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/perf/arm-cmn.c +2 -1
@@ -2243,7 +2243,8 @@ static enum cmn_node_type arm_cmn_subtype(enum cmn_node_type type) } } -static int arm_cmn_discover (struct arm_cmn *cmn,unsigned int rgn_offset) +static noinline_for_stack int arm_cmn_discover(struct arm_cmn *cmn, +unsigned int rgn_offset) {void __iomem *cfg_region;struct arm_cmn_node cfg, *dn;
Signature · 1 line
2.39.5
Robin Murphy
maintainerQuoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This function has a rather large stack usage, which triggers the warning limit with clang if I reduce the default to 1280 bytes:
drivers/perf/arm-cmn.c:2541:12: error: stack frame size (1312) exceeds limit (1280) in 'arm_cmn_probe' [-Werror,-Wframe-larger-than]This is a combination of two problems:
- The
arm_cmn_discover()function has some large local variables and gets inlined here by clang (but not gcc)
Quoted 6 lines
- The (struct pmu) assignment adds an extra copy of the pmu structure on the stack and does a
memcpy()from thatAddress the first one here by marking
arm_cmn_discover()asnoinline_for_stack, making clang behave more like gcc here. This gets it under the warning limit, though the total stack usage does not actually get reduced.
At that point, though, it seems like we may as well just disable the warning :/
Fortunately it's not actually that hard to improve matters here, so I've just sent that patch:
Quoted 4 lines
It would be nice to also change the way struct pmu is initialized, but I see that this is done consistently for all pmu drivers. Ideally the function pointers should be moved into a 'static const' structure per driver as this is done in most other subsystems.
Beware that perf_pmu_register() does some further dynamic assignment of callbacks based on what the driver provided, so it's not necessarily straightforward to change in struct pmu itself. However, FWIW I have recently been playing with some ideas for reducing the amount of PMU registration boilerplate, and indeed one of them is to have a driver-level static template passed to a registration helper, which would at least make it easy to avoid the full by-value copies everywhere.
Thanks,
Robin.
Quoted 20 lines
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/perf/arm-cmn.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/perf/arm-cmn.c +2
-1@@ -2243,7 +2243,8 @@ static enum cmn_node_type arm_cmn_subtype(enum cmn_node_type type) } } -static int arm_cmn_discover (struct arm_cmn *cmn,unsigned int rgn_offset) +static noinline_for_stack int arm_cmn_discover(struct arm_cmn *cmn, +unsigned int rgn_offset) {void __iomem *cfg_region;struct arm_cmn_node cfg, *dn;
Quoted 4 lines · Robin Murphy
On 20/06/2025 12:51 pm, Arnd Bergmann wrote:
At that point, though, it seems like we may as well just disable the warning :/
I had a couple of cases like this, where the same large stack happens on both gcc and clang, and adding noinline makes clang behave the same way as gcc, so neither of them warns. Leaving the warning enabled at this point at least ensures that we catch it if it ever increases further.
There is a different type of problem (mostly on powerpc and mips, but sometimes on arm64) where the 'noinline' helps clang to not produce some really bad object code with unnecessary temporaries on the stack.
Quoted 4 lines
Fortunately it's not actually that hard to improve matters here, so I've just sent that patch:
Nice, your version reduces the stack size from 1360 to 784 bytes for my test randconfig, so that's clearly better than my version.
While attempting to reproduce this now, I also found that another patch I had avoided the warning: I added -finline-max-stacksize=128 to the KASAN cflags, to work around some overeager inlining on powerpc, and this had the same effect as my patch, but without actually having to modify the sources.
Arnd