FAILED: patch "[PATCH] net/mlx5: Add error handling in" failed to apply to 5.4-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y
git checkout FETCH_HEAD
git cherry-pick -x c6bb8a21cdad8c975a3a646b9e5c8df01ad29783
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025062012-sassy-perm-01be@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From c6bb8a21cdad8c975a3a646b9e5c8df01ad29783 Mon Sep 17 00:00:00 2001
From: Wentao Liang <[email protected]>
Date: Sun, 25 May 2025 00:34:25 +0800
Subject: [PATCH] net/mlx5: Add error handling in
mlx5_query_nic_vport_node_guid()
The function mlx5_query_nic_vport_node_guid() calls the function mlx5_query_nic_vport_context() but does not check its return value. A proper implementation can be found in mlx5_nic_vport_query_local_lb().
Add error handling for mlx5_query_nic_vport_context(). If it fails, free the out buffer via kvfree() and return error code.
drivers/net/ethernet/mellanox/mlx5/core/vport.c +6 -3
@@ -465,19 +465,22 @@ int mlx5_query_nic_vport_node_guid(struct mlx5_core_dev *mdev, u64 *node_guid) {u32 *out;int outlen =MLX5_ST_SZ_BYTES (query_nic_vport_context_out); +int err; out =kvzalloc (outlen,GFP_KERNEL );if (!out)return -ENOMEM ; -mlx5_query_nic_vport_context (mdev,0 , out); + err =mlx5_query_nic_vport_context (mdev,0 , out); +if (err) + goto out; *node_guid =MLX5_GET64 (query_nic_vport_context_out, out, nic_vport_context.node_guid); - +out:kvfree (out); -return 0 ; +return err; }EXPORT_SYMBOL_GPL (mlx5_query_nic_vport_node_guid);