Skip to contentSkip to conversation

drm/msm/dp: include linux/io.h

PATCH In review Arnd Bergmann 2 participants 2 messages Jun 20, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/dp: include linux/io.h

From: Arnd Bergmann <[email protected]>

The driver started using readl/writel, which are defined in linux/io.h, so this needs to be included here:

drivers/gpu/drm/msm/dp/dp_panel.c:33:9: error: call to undeclared function 'readl_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
33 | return readl_relaxed(panel->link_base + offset);

Fixes 9d47325ee063 ("drm/msm/dp: drop the msm_dp_catalog module")
---
 drivers/gpu/drm/msm/dp/dp_panel.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/msm/dp/dp_panel.c +1 -0
index 489e39f6c0ac..ecd5d3665541 100644
@@ -2,6 +2,7 @@
 /*
  * Copyright (c) 2012-2020, The Linux Foundation. All rights reserved.
  */
+#include <linux/io.h>
 
 #include "dp_panel.h"
 #include "dp_reg.h"
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The driver started using readl/writel, which are defined in linux/io.h, so this needs to be included here:

drivers/gpu/drm/msm/dp/dp_panel.c:33:9: error: call to undeclared function 'readl_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
33 | return readl_relaxed(panel->link_base + offset);

Fixes 9d47325ee063 ("drm/msm/dp: drop the msm_dp_catalog module")