Skip to contentSkip to conversation

arm64: dts: socfpga: agilex: fix dtbs_check warning for fs2-free-clk

PATCH New Dinh Nguyen 1 participant 7 messages Jun 22, 2025

Subsystems (2)
lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/6 arm64: dts: socfpga: agilex: fix dtbs_check warning for fs2-free-clk

The f2s-free-clk requires a clock-frequency value. We put in an arbitrary value of 100 MHz for a constant. The true clock frequency would get generated in an FPGA design and the bootloader will populated in actual hardware designs.

This fixes warning like this:

arch/arm64/boot/dts/intel:34:8
4 f2s-free-clk (fixed-clock): 'clock-frequency' is a required property

---
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi +1 -0
index a77a504effea..c1e66db0f4c5 100644
@@ -126,6 +126,7 @@ cb_intosc_ls_clk: cb-intosc-ls-clk {
 		f2s_free_clk: f2s-free-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <100000000>;
 		};
 
 		osc1: osc1 {
Signature · 1 line
2.42.0.411.g813d9a9188
author maintainer
#1 lore raw

PATCH 2/6 arm64: dts: socfpga: stratix10: fix dtbs_check for rstmgr

Add the default "altr,rst-mgr" to the rstmgr node on Stratix10.

This fixes this warning:

arch/arm64/boot/dts/altera:33:10
rstmgr@ffd11000 (altr,stratix10-rst-mgr): compatible: 'oneOf' conditional failed, one must be fixed:

---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +1 -1
index 0def0b0daaf7..f0f659139f22 100644
@@ -395,7 +395,7 @@ pinctrl1: pinctrl@ffd13100 {
 
 		rst: rstmgr@ffd11000 {
 			#reset-cells = <1>;
-			compatible = "altr,stratix10-rst-mgr";
+			compatible = "altr,stratix10-rst-mgr", "altr,rst-mgr";
 			reg = <0xffd11000 0x1000>;
 		};
 
Signature · 1 line
2.42.0.411.g813d9a9188
author maintainer
#2 lore raw

PATCH 3/6 arm64: dts: socfpga: swvp: remove altr,modrst-offset

In reply to Dinh Nguyen

'altr,modrst-offset' property is not applicable for arm64 SoCFPGA platforms.

This will fix this dtbs_check warning:

socfpga_stratix10_swvp.dtb:
rstmgr@ffd11000: altr,modrst-offset: False schema does not allow 32

---
 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts +0 -4
index 34ccf8138f7b..33a765c9177d 100644
@@ -103,10 +103,6 @@ &usb1 {
 	status = "okay";
 };
 
-&rst {
-	altr,modrst-offset = <0x20>;
-};
-
 &sysmgr {
 	reg = <0xffd12000 0x1000>;
 	interrupts = <0x0 0x10 0x4>;
Signature · 1 line
2.42.0.411.g813d9a9188
author maintainer
#3 lore raw

PATCH 4/6 arm64: dts: stratix10: add clock-frequency to FPGA fixed-clocks

In reply to Dinh Nguyen

Add an arbitrary 100MHz for clock-frequency for the following clocks:
cb-intosc-ls-clk and f2s-free-clk.

This will fix the following warnings:
socfpga_stratix10_swvp.dtb:
cb-intosc-ls-clk: 'clock-frequency' is a required property
f2s-free-clk: 'clock-frequency' is a required property

---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +3 -0
index f0f659139f22..d024200c3031 100644
@@ -130,16 +130,19 @@ clocks {
 		cb_intosc_hs_div2_clk: cb-intosc-hs-div2-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <100000000>;
 		};
 
 		cb_intosc_ls_clk: cb-intosc-ls-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <100000000>;
 		};
 
 		f2s_free_clk: f2s-free-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <100000000>;
 		};
 
 		osc1: osc1 {
Signature · 1 line
2.42.0.411.g813d9a9188
author maintainer
#4 lore raw

PATCH 4/6 arm64: dts: stratix10: add clock-frequency to FPGA fixed-clocks

In reply to Dinh Nguyen

Add an arbitrary 100MHz for clock-frequency for the following clocks:
cb-intosc-ls-clk and f2s-free-clk.

This will fix the following warnings:
socfpga_stratix10_swvp.dtb:
cb-intosc-ls-clk: 'clock-frequency' is a required property
f2s-free-clk: 'clock-frequency' is a required property

---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +3 -0
index f0f659139f22..d024200c3031 100644
@@ -130,16 +130,19 @@ clocks {
 		cb_intosc_hs_div2_clk: cb-intosc-hs-div2-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <100000000>;
 		};
 
 		cb_intosc_ls_clk: cb-intosc-ls-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <100000000>;
 		};
 
 		f2s_free_clk: f2s-free-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <100000000>;
 		};
 
 		osc1: osc1 {
Signature · 1 line
2.42.0.411.g813d9a9188
author maintainer
#5 lore raw

PATCH 5/6 arm64: dts: stratix10: remove cpu1-start-addr

In reply to Dinh Nguyen

The cpu1-start-addr property is only applicable to 32-bit SoCFPGA platforms.

Removing this property will take care of warnings like this:
socfpga_stratix10_swvp.dtb: sysmgr@ffd12000: cpu1-start-addr:

	False schema does not allow 4291846704
---
 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts +0 -1
index 33a765c9177d..6b9fe154f677 100644
@@ -106,5 +106,4 @@ &usb1 {
 &sysmgr {
 	reg = <0xffd12000 0x1000>;
 	interrupts = <0x0 0x10 0x4>;
-	cpu1-start-addr = <0xffd06230>;
 };
Signature · 1 line
2.42.0.411.g813d9a9188
author maintainer
#6 lore raw

PATCH 6/6 arm64: dts: socfpga_swvp: remove phy-addr in the GMAC node

In reply to Dinh Nguyen

This addresses this warning:
socfpga_stratix10_swvp.dtb: ethernet@ff800000 (altr,socfpga-stmmac-a10-s10):
'phy-addr' does not match any of the regexes: '^pinctrl-[0-9]+$'

---
 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts +0 -1
index 6b9fe154f677..ad52e8a0b9ba 100644
@@ -68,7 +68,6 @@ &gmac0 {
 &gmac1 {
 	status = "okay";
 	phy-mode = "rgmii";
-	phy-addr = <0xffffffff>;
 };
 
 &gmac2 {
Signature · 1 line
2.42.0.411.g813d9a9188